remove support for version 30, since we don't implement FEC at all

This commit is contained in:
Lucas Clemente
2016-05-02 20:53:15 +02:00
parent 53ef5669e2
commit daf4e4a867
4 changed files with 2 additions and 15 deletions

View File

@@ -146,12 +146,7 @@ func (h *CryptoSetup) isInchoateCHLO(cryptoData map[Tag][]byte) bool {
}
func (h *CryptoSetup) handleInchoateCHLO(data []byte) ([]byte, error) {
var chloOrNil []byte
if h.version > protocol.VersionNumber(30) {
chloOrNil = data
}
proof, err := h.scfg.Sign(chloOrNil)
proof, err := h.scfg.Sign(data)
if err != nil {
return nil, err
}

View File

@@ -120,13 +120,6 @@ var _ = Describe("Crypto setup", func() {
Expect(signer.gotCHLO).To(BeTrue())
})
It("generates REJ messages for version 30", func() {
cs.version = protocol.VersionNumber(30)
_, err := cs.handleInchoateCHLO(sampleCHLO)
Expect(err).ToNot(HaveOccurred())
Expect(signer.gotCHLO).To(BeFalse())
})
It("generates SHLO messages", func() {
response, err := cs.handleCHLO([]byte("chlo-data"), map[Tag][]byte{
TagPUBS: []byte("pubs-c"),

View File

@@ -11,7 +11,6 @@ type VersionNumber int
// SupportedVersions lists the versions that the server supports
var SupportedVersions = []VersionNumber{
30,
32,
}

View File

@@ -19,7 +19,7 @@ var _ = Describe("Version", func() {
})
It("has proper tag list", func() {
Expect(protocol.SupportedVersionsAsTags).To(Equal([]byte("Q030Q032")))
Expect(protocol.SupportedVersionsAsTags).To(Equal([]byte("Q032")))
})
It("recognizes supported versions", func() {