gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

wire: correctly parse multi-byte frame types (#3736)

Browse Source
This commit is contained in:
Marten Seemann
2023-04-19 14:42:23 +02:00
committed by GitHub
parent 3f06880917
commit da26f91905
42 changed files with 262 additions and 394 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
internal/wire/crypto_frame_test.go
View File

@@ -2,6 +2,7 @@ package wire
import (
"bytes"
"io"
"github.com/quic-go/quic-go/internal/protocol"
"github.com/quic-go/quic-go/quicvarint"
@@ -13,9 +14,8 @@ import (
var _ = Describe("CRYPTO frame", func() {
Context("when parsing", func() {
It("parses", func() {
data := []byte{0x6}
data = append(data, encodeVarInt(0xdecafbad)...) // offset
data = append(data, encodeVarInt(6)...) // length
data := encodeVarInt(0xdecafbad) // offset
data = append(data, encodeVarInt(6)...) // length
data = append(data, []byte("foobar")...)
r := bytes.NewReader(data)
frame, err := parseCryptoFrame(r, protocol.Version1)
@@ -26,15 +26,15 @@ var _ = Describe("CRYPTO frame", func() {
})
It("errors on EOFs", func() {
data := []byte{0x6}
data = append(data, encodeVarInt(0xdecafbad)...) // offset
data = append(data, encodeVarInt(6)...) // data length
data := encodeVarInt(0xdecafbad) // offset
data = append(data, encodeVarInt(6)...) // data length
data = append(data, []byte("foobar")...)
_, err := parseCryptoFrame(bytes.NewReader(data), protocol.Version1)
r := bytes.NewReader(data)
_, err := parseCryptoFrame(r, protocol.Version1)
Expect(err).NotTo(HaveOccurred())
for i := range data {
_, err := parseCryptoFrame(bytes.NewReader(data[0:i]), protocol.Version1)
Expect(err).To(HaveOccurred())
_, err := parseCryptoFrame(bytes.NewReader(data[:i]), protocol.Version1)
Expect(err).To(MatchError(io.EOF))
}
})
})