rename LargestObserved to LargestAcked in QUIC 34 ACK frame

This commit is contained in:
Marten Seemann
2016-06-24 14:29:00 +07:00
parent ab1db83134
commit d86d981319
7 changed files with 140 additions and 141 deletions

View File

@@ -148,15 +148,15 @@ func (h *sentPacketHandler) SentPacket(packet *Packet) error {
// TODO: Simplify return types
func (h *sentPacketHandler) ReceivedAck(ackFrame *frames.AckFrameNew) error {
if ackFrame.LargestObserved > h.lastSentPacketNumber {
if ackFrame.LargestAcked > h.lastSentPacketNumber {
return errAckForUnsentPacket
}
if ackFrame.LargestObserved <= h.LargestObserved { // duplicate or out-of-order AckFrame
if ackFrame.LargestAcked <= h.LargestObserved { // duplicate or out-of-order AckFrame
return ErrDuplicateOrOutOfOrderAck
}
h.LargestObserved = ackFrame.LargestObserved
h.LargestObserved = ackFrame.LargestAcked
// Update the RTT
timeDelta := time.Now().Sub(h.packetHistory[h.LargestObserved].sendTime)
@@ -170,7 +170,7 @@ func (h *sentPacketHandler) ReceivedAck(ackFrame *frames.AckFrameNew) error {
var lostPackets congestion.PacketVector
ackRangeIndex := 0
for i := ackFrame.LowestAcked; i <= ackFrame.LargestObserved; i++ {
for i := ackFrame.LowestAcked; i <= ackFrame.LargestAcked; i++ {
if ackFrame.HasMissingRanges() {
ackRange := ackFrame.AckRanges[len(ackFrame.AckRanges)-1-ackRangeIndex]