gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

disable FIN-packing optimization, increasing transfer rate by 5%

Browse Source
This commit is contained in:
Lucas Clemente
2016-09-05 00:45:21 +02:00
parent 934fc5b6a0
commit d837cd96b2
2 changed files with 9 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
stream_framer.go
View File

@@ -1,8 +1,6 @@
package quic
import (
"runtime"
"github.com/lucas-clemente/quic-go/flowcontrol"
"github.com/lucas-clemente/quic-go/frames"
"github.com/lucas-clemente/quic-go/protocol"
@@ -102,13 +100,7 @@ func (f *streamFramer) maybePopNormalFrames(maxBytes protocol.ByteCount) (res []
data := s.getDataForWriting(maxLen)
// Here, stream.Write() may return in parallel. Afterwards, the user may
// call stream.Close(). We want to pack the FIN into the same frame,
// so we speculatively allow the other goroutines to run.
// In tests, this increased the percentage of FINs packed into the same
// frame from ~20% to ~97%.
runtime.Gosched()
// This is unlikely, but check it nonetheless, the scheduler might have jumped in. Seems to happen in ~20% of cases in the tests.
shouldSendFin := s.shouldSendFin()
if data == nil && !shouldSendFin {
return true, nil