gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

don't qlog a packet number for Retry packets

Browse Source
This commit is contained in:
Marten Seemann
2020-04-04 15:05:34 +07:00
parent 383dab3ce7
commit d6edcc38c0
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
qlog/packet_header.go
View File

@@ -72,7 +72,7 @@ type packetHeader struct {
} }
func (h packetHeader) MarshalJSONObject(enc *gojay.Encoder) { func (h packetHeader) MarshalJSONObject(enc *gojay.Encoder) {
enc.Int64Key("packet_number", int64(h.PacketNumber)) enc.Int64KeyOmitEmpty("packet_number", int64(h.PacketNumber))
enc.Int64KeyOmitEmpty("payload_length", int64(h.PayloadLength)) enc.Int64KeyOmitEmpty("payload_length", int64(h.PayloadLength))
enc.Int64KeyOmitEmpty("packet_size", int64(h.PacketSize)) enc.Int64KeyOmitEmpty("packet_size", int64(h.PacketSize))
if h.Version != 0 { if h.Version != 0 {

5
qlog/qlog_test.go
View File

@@ -306,6 +306,11 @@ var _ = Describe("Tracer", func() {
ev := entry.Event ev := entry.Event
Expect(ev).To(HaveKeyWithValue("packet_type", "retry")) Expect(ev).To(HaveKeyWithValue("packet_type", "retry"))
Expect(ev).To(HaveKey("header")) Expect(ev).To(HaveKey("header"))
header := ev["header"]
Expect(header).ToNot(HaveKey("packet_number"))
Expect(header).To(HaveKey("version"))
Expect(header).To(HaveKey("dcid"))
Expect(header).To(HaveKey("scid"))
Expect(ev).ToNot(HaveKey("frames")) Expect(ev).ToNot(HaveKey("frames"))
}) })