use a uint8 to represent the key phase bit

This commit is contained in:
Marten Seemann
2020-10-06 15:25:31 +07:00
parent 93e3873141
commit d5a30225ce
4 changed files with 29 additions and 19 deletions

View File

@@ -3,23 +3,34 @@ package protocol
// KeyPhase is the key phase
type KeyPhase uint64
// Bit determines the key phase bit
func (p KeyPhase) Bit() KeyPhaseBit {
return p%2 == 1
if p%2 == 0 {
return KeyPhaseZero
}
return KeyPhaseOne
}
// KeyPhaseBit is the key phase bit
type KeyPhaseBit bool
type KeyPhaseBit uint8
const (
// KeyPhaseUndefined is an undefined key phase
KeyPhaseUndefined KeyPhaseBit = iota
// KeyPhaseZero is key phase 0
KeyPhaseZero KeyPhaseBit = false
KeyPhaseZero
// KeyPhaseOne is key phase 1
KeyPhaseOne KeyPhaseBit = true
KeyPhaseOne
)
func (p KeyPhaseBit) String() string {
if p == KeyPhaseZero {
//nolint:exhaustive
switch p {
case KeyPhaseZero:
return "0"
case KeyPhaseOne:
return "1"
default:
return "undefined"
}
return "1"
}

View File

@@ -6,6 +6,11 @@ import (
)
var _ = Describe("Key Phases", func() {
It("has undefined as its default value", func() {
var k KeyPhaseBit
Expect(k).To(Equal(KeyPhaseUndefined))
})
It("has the correct string representation", func() {
Expect(KeyPhaseZero.String()).To(Equal("0"))
Expect(KeyPhaseOne.String()).To(Equal("1"))