From 9bc8822585882767bd6d1a16944c29b78e12c227 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sun, 8 Mar 2020 14:14:15 +0700 Subject: [PATCH] remove superflous case when queueing undecryptable packets This was only needed in gQUIC. In IETF QUIC, we determine the keys from the packet header. The crypto setup will return an ErrKeysDropped if we already dropped the corresponding keys. --- session.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/session.go b/session.go index c7e89eb16..3cf30bb7c 100644 --- a/session.go +++ b/session.go @@ -1495,12 +1495,8 @@ func (s *session) scheduleSending() { } func (s *session) tryQueueingUndecryptablePacket(p *receivedPacket) { - if s.handshakeComplete { - s.logger.Debugf("Received undecryptable packet from %s after the handshake (%d bytes)", p.remoteAddr.String(), len(p.data)) - return - } if len(s.undecryptablePackets)+1 > protocol.MaxUndecryptablePackets { - s.logger.Infof("Dropping undecrytable packet (%d bytes). Undecryptable packet queue full.", len(p.data)) + s.logger.Infof("Dropping undecryptable packet (%d bytes). Undecryptable packet queue full.", len(p.data)) return } s.logger.Infof("Queueing packet (%d bytes) for later decryption", len(p.data))