remove unused RTTStats from the received packet handler (#4287)

internal/ackhandler/ackhandler.go

@@ -20,5 +20,5 @@ func NewAckHandler(
 	logger utils.Logger,
 ) (SentPacketHandler, ReceivedPacketHandler) {
 	sph := newSentPacketHandler(initialPacketNumber, initialMaxDatagramSize, rttStats, clientAddressValidated, enableECN, pers, tracer, logger)
-	return sph, newReceivedPacketHandler(sph, rttStats, logger)
+	return sph, newReceivedPacketHandler(sph, logger)
 }

internal/ackhandler/received_packet_handler.go

@@ -21,16 +21,12 @@ type receivedPacketHandler struct {
 
 var _ ReceivedPacketHandler = &receivedPacketHandler{}
 
-func newReceivedPacketHandler(
+func newReceivedPacketHandler(sentPackets sentPacketTracker, logger utils.Logger) ReceivedPacketHandler {
-	sentPackets sentPacketTracker,
-	rttStats *utils.RTTStats,
-	logger utils.Logger,
-) ReceivedPacketHandler {
 	return &receivedPacketHandler{
 		sentPackets:      sentPackets,
-		initialPackets:   newReceivedPacketTracker(rttStats, logger),
+		initialPackets:   newReceivedPacketTracker(logger),
-		handshakePackets: newReceivedPacketTracker(rttStats, logger),
+		handshakePackets: newReceivedPacketTracker(logger),
-		appDataPackets:   newReceivedPacketTracker(rttStats, logger),
+		appDataPackets:   newReceivedPacketTracker(logger),
 		lowest1RTTPacket: protocol.InvalidPacketNumber,
 	}
 }

internal/ackhandler/received_packet_handler_test.go

@@ -18,11 +18,7 @@ var _ = Describe("Received Packet Handler", func() {
 
 	BeforeEach(func() {
 		sentPackets = NewMockSentPacketTracker(mockCtrl)
-		handler = newReceivedPacketHandler(
+		handler = newReceivedPacketHandler(sentPackets, utils.DefaultLogger)
-			sentPackets,
-			&utils.RTTStats{},
-			utils.DefaultLogger,
-		)
 	})
 
 	It("generates ACKs for different packet number spaces", func() {

internal/ackhandler/received_packet_tracker.go

@@ -21,7 +21,6 @@ type receivedPacketTracker struct {
 	packetHistory *receivedPacketHistory
 
 	maxAckDelay time.Duration
-	rttStats    *utils.RTTStats
 
 	hasNewAck bool // true as soon as we received an ack-eliciting new packet
 	ackQueued bool // true once we received more than 2 (or later in the connection 10) ack-eliciting packets
@@ -33,14 +32,10 @@ type receivedPacketTracker struct {
 	logger utils.Logger
 }
 
-func newReceivedPacketTracker(
+func newReceivedPacketTracker(logger utils.Logger) *receivedPacketTracker {
-	rttStats *utils.RTTStats,
-	logger utils.Logger,
-) *receivedPacketTracker {
 	return &receivedPacketTracker{
 		packetHistory: newReceivedPacketHistory(),
 		maxAckDelay:   protocol.MaxAckDelay,
-		rttStats:      rttStats,
 		logger:        logger,
 	}
 }

internal/ackhandler/received_packet_tracker_test.go

@@ -12,14 +12,10 @@ import (
 )
 
 var _ = Describe("Received Packet Tracker", func() {
-	var (
+	var tracker *receivedPacketTracker
-		tracker  *receivedPacketTracker
-		rttStats *utils.RTTStats
-	)
 
 	BeforeEach(func() {
-		rttStats = &utils.RTTStats{}
+		tracker = newReceivedPacketTracker(utils.DefaultLogger)
-		tracker = newReceivedPacketTracker(rttStats, utils.DefaultLogger)
 	})
 
 	Context("accepting packets", func() {