gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix race condition when setting up TLS sessions in the server

Browse Source
This commit is contained in:
Marten Seemann
2018-03-07 10:52:30 +07:00
parent 77a419898c
commit d3297f0734
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
server.go
View File

@@ -140,10 +140,11 @@ func (s *server) setupTLS() error {
case tlsSession := <-sessionChan: case tlsSession := <-sessionChan:
connID := tlsSession.connID connID := tlsSession.connID
sess := tlsSession.sess sess := tlsSession.sess
s.sessionsMutex.Lock()
if _, ok := s.sessions[connID]; ok { // drop this session if it already exists if _, ok := s.sessions[connID]; ok { // drop this session if it already exists
s.sessionsMutex.Unlock()
continue continue
} }
s.sessionsMutex.Lock()
s.sessions[connID] = sess s.sessions[connID] = sess
s.sessionsMutex.Unlock() s.sessionsMutex.Unlock()
s.runHandshakeAndSession(sess, connID) s.runHandshakeAndSession(sess, connID)