gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove check for CONGESTION_FEEDBACK in the packet unpacker

Browse Source 
CONGESTION_FEEDBACK was reserved for future use in gQUIC, but has never
actually been implemented. It won't make it to IETF QUIC, so we don't
need to check for it. Note that we'd still reject a CONGESTION_FEEDBACK
frame, since we're rejecting any unknown frame type.
This commit is contained in:
Marten Seemann
2017-11-01 15:49:34 +07:00
parent 1f644debd4
commit ccb2e9a2df
2 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packet_unpacker_test.go
View File

@@ -92,12 +92,6 @@ var _ = Describe("Packet unpacker", func() {
Expect(readFrame.LargestAcked).To(Equal(protocol.PacketNumber(0x13)))
})
It("errors on CONGESTION_FEEDBACK frames", func() {
setData([]byte{0x20})
_, err := unpacker.Unpack(hdrBin, hdr, data)
Expect(err).To(MatchError("unimplemented: CONGESTION_FEEDBACK"))
})
It("handles PADDING frames", func() {
setData([]byte{0, 0, 0}) // 3 bytes PADDING
packet, err := unpacker.Unpack(hdrBin, hdr, data)