Merge pull request #2804 from lucas-clemente/check-quic-transport-parameter-extension

fail the handshake if the quic_transport_parameter extension is missing
2020-09-26 17:53:51 +07:00
parent 02274b6cb5 98c437e98e
commit c92b0379cf
1 changed files with 5 additions and 1 deletions
--- a/internal/handshake/crypto_setup.go
+++ b/internal/handshake/crypto_setup.go
@@ -340,7 +340,11 @@ readLoop:
 	for {
 		select {
 		case data := <-h.paramsChan:
-			h.handleTransportParameters(data)
+			if data == nil {
+				h.onError(0x6d, "missing quic_transport_parameters extension")
+			} else {
+				h.handleTransportParameters(data)
+			}
 		case <-h.isReadingHandshakeMessage:
 			break readLoop
 		case <-h.handshakeDone: