From c7119b2adfc8e79b8572d2b4d25841edd4805fa1 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Thu, 10 May 2018 13:12:02 +0900 Subject: [PATCH] move logging of connection closing to the session --- client.go | 1 - session.go | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client.go b/client.go index 4bd98f625..e9f575408 100644 --- a/client.go +++ b/client.go @@ -248,7 +248,6 @@ func (c *client) establishSecureConnection() error { go func() { runErr = c.session.run() // returns as soon as the session is closed close(errorChan) - c.logger.Infof("Connection %s closed.", c.srcConnID) if runErr != handshake.ErrCloseSessionForRetry && runErr != errCloseSessionForNewVersion { c.conn.Close() } diff --git a/session.go b/session.go index 2450d6fa9..9cfa1f301 100644 --- a/session.go +++ b/session.go @@ -533,6 +533,7 @@ runLoop: s.handshakeChan <- closeErr.err } s.handleCloseError(closeErr) + s.logger.Infof("Connection %s closed.", s.srcConnID) return closeErr.err } @@ -839,7 +840,7 @@ func (s *session) handleCloseError(closeErr closeError) error { } // Don't log 'normal' reasons if quicErr.ErrorCode == qerr.PeerGoingAway || quicErr.ErrorCode == qerr.NetworkIdleTimeout { - s.logger.Infof("Closing connection %s", s.srcConnID) + s.logger.Infof("Closing connection %s.", s.srcConnID) } else { s.logger.Errorf("Closing session with error: %s", closeErr.err.Error()) }