gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

Merge pull request #2683 from lucas-clemente/remove-reno-congestion-stats

Browse Source 
remove unused connectionStats counters from the Reno implementation
This commit is contained in:
Marten Seemann
2020-07-22 22:16:00 +07:00
committed by GitHub
parent f7ec9da9d9 74e32d6762
commit bc8b37cd14
2 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/congestion/cubic_sender.go
View File

@@ -21,7 +21,6 @@ const (
type cubicSender struct { type cubicSender struct {
hybridSlowStart HybridSlowStart hybridSlowStart HybridSlowStart
rttStats *RTTStats rttStats *RTTStats
stats connectionStats
cubic *Cubic cubic *Cubic
pacer *pacer pacer *pacer
clock Clock clock Clock
@@ -169,8 +168,6 @@ func (c *cubicSender) OnPacketLost(
// already sent should be treated as a single loss event, since it's expected. // already sent should be treated as a single loss event, since it's expected.
if packetNumber <= c.largestSentAtLastCutback { if packetNumber <= c.largestSentAtLastCutback {
if c.lastCutbackExitedSlowstart { if c.lastCutbackExitedSlowstart {
c.stats.slowstartPacketsLost++
c.stats.slowstartBytesLost += lostBytes
if c.slowStartLargeReduction { if c.slowStartLargeReduction {
// Reduce congestion window by lost_bytes for every loss. // Reduce congestion window by lost_bytes for every loss.
c.congestionWindow = utils.MaxByteCount(c.congestionWindow-lostBytes, c.minSlowStartExitWindow) c.congestionWindow = utils.MaxByteCount(c.congestionWindow-lostBytes, c.minSlowStartExitWindow)
@@ -180,9 +177,6 @@ func (c *cubicSender) OnPacketLost(
return return
} }
c.lastCutbackExitedSlowstart = c.InSlowStart() c.lastCutbackExitedSlowstart = c.InSlowStart()
if c.InSlowStart() {
c.stats.slowstartPacketsLost++
}
// TODO(chromium): Separate out all of slow start into a separate class. // TODO(chromium): Separate out all of slow start into a separate class.
if c.slowStartLargeReduction && c.InSlowStart() { if c.slowStartLargeReduction && c.InSlowStart() {

8
internal/congestion/stats.go
View File

@@ -1,8 +0,0 @@
package congestion
import "github.com/lucas-clemente/quic-go/internal/protocol"
type connectionStats struct {
slowstartPacketsLost protocol.PacketNumber
slowstartBytesLost protocol.ByteCount
}