From bc54c50b7eaa88311001a9c042c90221f6c2173a Mon Sep 17 00:00:00 2001
From: Lucas Clemente <lucas@clemente.io>
Date: Mon, 5 Sep 2016 23:21:17 +0200
Subject: [PATCH] replace CachingReader with io.TeeReader

---
 handshake/crypto_setup.go    |  8 ++++----
 utils/caching_reader.go      | 35 -----------------------------------
 utils/caching_reader_test.go | 36 ------------------------------------
 3 files changed, 4 insertions(+), 75 deletions(-)
 delete mode 100644 utils/caching_reader.go
 delete mode 100644 utils/caching_reader_test.go

diff --git a/handshake/crypto_setup.go b/handshake/crypto_setup.go
index 900d58c2b..91b33a8d9 100644
--- a/handshake/crypto_setup.go
+++ b/handshake/crypto_setup.go
@@ -3,6 +3,7 @@ package handshake
 import (
 	"bytes"
 	"crypto/rand"
+	"io"
 	"net"
 	"sync"
 
@@ -70,19 +71,18 @@ func NewCryptoSetup(
 // HandleCryptoStream reads and writes messages on the crypto stream
 func (h *CryptoSetup) HandleCryptoStream() error {
 	for {
-		cachingReader := utils.NewCachingReader(h.cryptoStream)
-		messageTag, cryptoData, err := ParseHandshakeMessage(cachingReader)
+		var chloData bytes.Buffer
+		messageTag, cryptoData, err := ParseHandshakeMessage(io.TeeReader(h.cryptoStream, &chloData))
 		if err != nil {
 			return qerr.HandshakeFailed
 		}
 		if messageTag != TagCHLO {
 			return qerr.InvalidCryptoMessageType
 		}
-		chloData := cachingReader.Get()
 
 		utils.Debugf("Got CHLO:\n%s", printHandshakeMessage(cryptoData))
 
-		done, err := h.handleMessage(chloData, cryptoData)
+		done, err := h.handleMessage(chloData.Bytes(), cryptoData)
 		if err != nil {
 			return err
 		}
diff --git a/utils/caching_reader.go b/utils/caching_reader.go
deleted file mode 100644
index e0203bedd..000000000
--- a/utils/caching_reader.go
+++ /dev/null
@@ -1,35 +0,0 @@
-package utils
-
-import "bytes"
-
-// CachingReader wraps a reader and saves all data it reads
-type CachingReader struct {
-	buf bytes.Buffer
-	r   ReadStream
-}
-
-// NewCachingReader returns a new CachingReader
-func NewCachingReader(r ReadStream) *CachingReader {
-	return &CachingReader{r: r}
-}
-
-// Read implements io.Reader
-func (r *CachingReader) Read(p []byte) (int, error) {
-	n, err := r.r.Read(p)
-	r.buf.Write(p[:n])
-	return n, err
-}
-
-// ReadByte implements io.ByteReader
-func (r *CachingReader) ReadByte() (byte, error) {
-	b, err := r.r.ReadByte()
-	if err == nil {
-		r.buf.WriteByte(b)
-	}
-	return b, err
-}
-
-// Get the data cached
-func (r *CachingReader) Get() []byte {
-	return r.buf.Bytes()
-}
diff --git a/utils/caching_reader_test.go b/utils/caching_reader_test.go
deleted file mode 100644
index 8f7513e50..000000000
--- a/utils/caching_reader_test.go
+++ /dev/null
@@ -1,36 +0,0 @@
-package utils
-
-import (
-	"bytes"
-
-	. "github.com/onsi/ginkgo"
-	. "github.com/onsi/gomega"
-)
-
-var _ = Describe("Caching reader", func() {
-	It("caches Read()", func() {
-		r := bytes.NewReader([]byte("foobar"))
-		cr := NewCachingReader(r)
-		p := make([]byte, 3)
-		n, err := cr.Read(p)
-		Expect(err).ToNot(HaveOccurred())
-		Expect(n).To(Equal(3))
-		Expect(p).To(Equal([]byte("foo")))
-		Expect(cr.Get()).To(Equal([]byte("foo")))
-	})
-
-	It("caches ReadByte()", func() {
-		r := bytes.NewReader([]byte("foobar"))
-		cr := NewCachingReader(r)
-		b, err := cr.ReadByte()
-		Expect(err).ToNot(HaveOccurred())
-		Expect(b).To(Equal(byte('f')))
-		b, err = cr.ReadByte()
-		Expect(err).ToNot(HaveOccurred())
-		Expect(b).To(Equal(byte('o')))
-		b, err = cr.ReadByte()
-		Expect(err).ToNot(HaveOccurred())
-		Expect(b).To(Equal(byte('o')))
-		Expect(cr.Get()).To(Equal([]byte("foo")))
-	})
-})