gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

reject version negotiation packets with an empty version list

Browse Source
This commit is contained in:
Marten Seemann
2017-10-14 13:25:20 -07:00
parent 7cb8e87580
commit bbe9affa27
4 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
internal/wire/public_header_test.go
View File

@@ -145,14 +145,10 @@ var _ = Describe("Public Header", func() {
Expect(b.Len()).To(BeZero())
})
It("parses a version negotiation packet that contains 0 versions", func() {
It("errors if it doesn't contain any versions", func() {
b := bytes.NewReader([]byte{0x9, 0xf6, 0x19, 0x86, 0x66, 0x9b, 0x9f, 0xfa, 0x4c})
hdr, err := ParsePublicHeader(b, protocol.PerspectiveServer, protocol.VersionUnknown)
Expect(err).ToNot(HaveOccurred())
Expect(hdr.VersionFlag).To(BeTrue())
Expect(hdr.VersionNumber).To(BeZero()) // unitialized
Expect(hdr.SupportedVersions).To(BeEmpty())
Expect(b.Len()).To(BeZero())
_, err := ParsePublicHeader(b, protocol.PerspectiveServer, protocol.VersionUnknown)
Expect(err).To(MatchError("InvalidVersionNegotiationPacket: empty version list"))
})
It("reads version negotiation packets containing unsupported versions", func() {