gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

http3: initialize trailer map with empty trailer entries when parsing the header (#4656)

Browse Source 
* feat: pre-populate trailers on response with empty values

* fix: improve comment/func name
This commit is contained in:
Kevin McDonald
2024-09-07 08:59:07 +02:00
committed by GitHub
parent 4f48b2ce25
commit b92bf0c80d
5 changed files with 61 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
integrationtests/self/http_test.go
View File

@@ -1024,6 +1024,7 @@ var _ = Describe("HTTP tests", func() {
mux.HandleFunc("/trailers", func(w http.ResponseWriter, r *http.Request) {
defer GinkgoRecover()
w.Header().Set("Trailer", "AtEnd1, AtEnd2")
w.Header().Add("Trailer", "Never")
w.Header().Add("Trailer", "LAST")
w.Header().Set("Content-Type", "text/plain; charset=utf-8") // normal header
w.WriteHeader(http.StatusOK)
@@ -1041,11 +1042,18 @@ var _ = Describe("HTTP tests", func() {
resp, err := client.Get(fmt.Sprintf("https://localhost:%d/trailers", port))
Expect(err).ToNot(HaveOccurred())
Expect(resp.StatusCode).To(Equal(200))
Expect(resp.Header.Values("Trailer")).To(Equal([]string{"AtEnd1, AtEnd2", "LAST"}))
Expect(resp.Header.Get("Trailer")).To(Equal(""))
Expect(resp.Header).To(Not(HaveKey("Atend1")))
Expect(resp.Header).To(Not(HaveKey("Atend2")))
Expect(resp.Header).To(Not(HaveKey("Never")))
Expect(resp.Header).To(Not(HaveKey("Last")))
Expect(resp.Header).To(Not(HaveKey("Late-Header")))
Expect(resp.Trailer).To(Equal(http.Header(map[string][]string{
"Atend1": nil,
"Atend2": nil,
"Never": nil,
"Last": nil,
})))
body, err := io.ReadAll(gbytes.TimeoutReader(resp.Body, 3*time.Second))
Expect(err).ToNot(HaveOccurred())