gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

make putting back packet buffers a member function of packetBuffer

Browse Source
This commit is contained in:
Marten Seemann
2018-12-30 15:28:52 +07:00
parent d3ea7c0c4c
commit b32fb438af
5 changed files with 35 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
buffer_pool.go
View File

@@ -22,6 +22,23 @@ func (b *packetBuffer) Split() {
b.refCount++
}
// Release decreases the refCount.
// It should be called when processing the packet is finished.
// When the refCount reaches 0, the packet buffer is put back into the pool.
func (b *packetBuffer) Release() {
if cap(b.Slice) != int(protocol.MaxReceivePacketSize) {
panic("putPacketBuffer called with packet of wrong size!")
}
b.refCount--
if b.refCount < 0 {
panic("negative packetBuffer refCount")
}
// only put the packetBuffer back if it's not used any more
if b.refCount == 0 {
bufferPool.Put(b)
}
}
var bufferPool sync.Pool
func getPacketBuffer() *packetBuffer {
@@ -31,20 +48,6 @@ func getPacketBuffer() *packetBuffer {
return buf
}
func putPacketBuffer(buf *packetBuffer) {
if cap(buf.Slice) != int(protocol.MaxReceivePacketSize) {
panic("putPacketBuffer called with packet of wrong size!")
}
buf.refCount--
if buf.refCount < 0 {
panic("negative packetBuffer refCount")
}
// only put the packetBuffer back if it's not used any more
if buf.refCount == 0 {
bufferPool.Put(buf)
}
}
func init() {
bufferPool.New = func() interface{} {
return &packetBuffer{