gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix several linter warnings and misspellings

Browse Source
This commit is contained in:
Marten Seemann
2016-05-02 16:33:32 +07:00
parent ce57f008e4
commit ad467ade58
9 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ackhandler/entropy_accumulator.go
View File

@@ -12,7 +12,7 @@ func (e *EntropyAccumulator) Add(packetNumber protocol.PacketNumber, entropyFlag
}
}
// Add the contribution of the entropy flag of a given packet number
// Substract the contribution of the entropy flag of a given packet number
func (e *EntropyAccumulator) Substract(packetNumber protocol.PacketNumber, entropyFlag bool) {
e.Add(packetNumber, entropyFlag)
}

1
ackhandler/interfaces.go
View File

@@ -25,6 +25,7 @@ type ReceivedPacketHandler interface {
DequeueAckFrame() *frames.AckFrame
}
// StopWaitingManager manages StopWaitings for sent packets
type StopWaitingManager interface {
RegisterPacketForRetransmission(packet *Packet)
GetStopWaitingFrame() *frames.StopWaitingFrame

6
ackhandler/packet.go
View File

@@ -21,8 +21,9 @@ type Packet struct {
sendTime time.Time
}
// GetStreamFramesForRetransmission gets all the streamframes for retransmission
func (p *Packet) GetStreamFramesForRetransmission() []*frames.StreamFrame {
streamFrames := make([]*frames.StreamFrame, 0)
var streamFrames []*frames.StreamFrame
for _, frame := range p.Frames {
if streamFrame, isStreamFrame := frame.(*frames.StreamFrame); isStreamFrame {
streamFrames = append(streamFrames, streamFrame)
@@ -31,8 +32,9 @@ func (p *Packet) GetStreamFramesForRetransmission() []*frames.StreamFrame {
return streamFrames
}
// GetControlFramesForRetransmission gets all the control frames for retransmission
func (p *Packet) GetControlFramesForRetransmission() []frames.Frame {
controlFrames := make([]frames.Frame, 0)
var controlFrames []frames.Frame
for _, frame := range p.Frames {
// omit ACKs
if _, isStreamFrame := frame.(*frames.StreamFrame); isStreamFrame {

1
ackhandler/received_packet_handler.go
View File

@@ -7,6 +7,7 @@ import (
"github.com/lucas-clemente/quic-go/protocol"
)
// ErrDuplicatePacket occurres when a duplicate packet is received
var ErrDuplicatePacket = errors.New("ReceivedPacketHandler: Duplicate Packet")
type receivedPacketHandler struct {

2
ackhandler/stop_waiting_manager.go
View File

@@ -20,7 +20,7 @@ func NewStopWaitingManager() StopWaitingManager {
}
}
// RegisterPacketForRetransmission prepares the StopWaitingFrame, if neccessary
// RegisterPacketForRetransmission prepares the StopWaitingFrame, if necessary
func (h *stopWaitingManager) RegisterPacketForRetransmission(packet *Packet) {
if h.currentStopWaitingFrame == nil || h.currentStopWaitingFrame.LeastUnacked <= packet.PacketNumber { // <= because for StopWaitingFrames LeastUnacked = packet.PacketNumber + 1
h.currentStopWaitingFrame = &frames.StopWaitingFrame{