From ab88e9472d2385a1b203162bdb1898c89baf7cb4 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Tue, 9 May 2017 12:15:21 +0800 Subject: [PATCH] fix infinite loop in session test fixes #598 The mockReceivedPacketHandler returned the same ACK frame over and over again, so that the loop in session.sendPacket() would send packets containing this packet indefinitely. --- session_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/session_test.go b/session_test.go index e0307b874..0b63c1fe2 100644 --- a/session_test.go +++ b/session_test.go @@ -103,7 +103,11 @@ type mockReceivedPacketHandler struct { nextAckFrame *frames.AckFrame } -func (m *mockReceivedPacketHandler) GetAckFrame() *frames.AckFrame { return m.nextAckFrame } +func (m *mockReceivedPacketHandler) GetAckFrame() *frames.AckFrame { + f := m.nextAckFrame + m.nextAckFrame = nil + return f +} func (m *mockReceivedPacketHandler) ReceivedPacket(packetNumber protocol.PacketNumber, shouldInstigateAck bool) error { panic("not implemented") }