gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

rename frame.Write to frame.Append

Browse Source
This commit is contained in:
Marten Seemann
2022-08-28 23:13:19 +03:00
parent 3ca1001951
commit ab6d664b43
50 changed files with 112 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
internal/wire/stream_frame_test.go
View File

@@ -145,7 +145,7 @@ var _ = Describe("STREAM frame", func() {
StreamID: 0x1337,
Data: []byte("foobar"),
}
b, err := f.Write(nil, protocol.Version1)
b, err := f.Append(nil, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
expected := []byte{0x8}
expected = append(expected, encodeVarInt(0x1337)...) // stream ID
@@ -159,7 +159,7 @@ var _ = Describe("STREAM frame", func() {
Offset: 0x123456,
Data: []byte("foobar"),
}
b, err := f.Write(nil, protocol.Version1)
b, err := f.Append(nil, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
expected := []byte{0x8 ^ 0x4}
expected = append(expected, encodeVarInt(0x1337)...) // stream ID
@@ -174,7 +174,7 @@ var _ = Describe("STREAM frame", func() {
Offset: 0x123456,
Fin: true,
}
b, err := f.Write(nil, protocol.Version1)
b, err := f.Append(nil, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
expected := []byte{0x8 ^ 0x4 ^ 0x1}
expected = append(expected, encodeVarInt(0x1337)...) // stream ID
@@ -188,7 +188,7 @@ var _ = Describe("STREAM frame", func() {
Data: []byte("foobar"),
DataLenPresent: true,
}
b, err := f.Write(nil, protocol.Version1)
b, err := f.Append(nil, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
expected := []byte{0x8 ^ 0x2}
expected = append(expected, encodeVarInt(0x1337)...) // stream ID
@@ -204,7 +204,7 @@ var _ = Describe("STREAM frame", func() {
DataLenPresent: true,
Offset: 0x123456,
}
b, err := f.Write(nil, protocol.Version1)
b, err := f.Append(nil, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
expected := []byte{0x8 ^ 0x4 ^ 0x2}
expected = append(expected, encodeVarInt(0x1337)...) // stream ID
@@ -219,7 +219,7 @@ var _ = Describe("STREAM frame", func() {
StreamID: 0x42,
Offset: 0x1337,
}
_, err := f.Write(nil, protocol.Version1)
_, err := f.Append(nil, protocol.Version1)
Expect(err).To(MatchError("StreamFrame: attempting to write empty frame without FIN"))
})
})
@@ -268,13 +268,13 @@ var _ = Describe("STREAM frame", func() {
if maxDataLen == 0 { // 0 means that no valid STREAM frame can be written
// check that writing a minimal size STREAM frame (i.e. with 1 byte data) is actually larger than the desired size
f.Data = []byte{0}
b, err := f.Write(nil, protocol.Version1)
b, err := f.Append(nil, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
Expect(len(b)).To(BeNumerically(">", i))
continue
}
f.Data = data[:int(maxDataLen)]
b, err := f.Write(nil, protocol.Version1)
b, err := f.Append(nil, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
Expect(len(b)).To(Equal(i))
}
@@ -294,13 +294,13 @@ var _ = Describe("STREAM frame", func() {
if maxDataLen == 0 { // 0 means that no valid STREAM frame can be written
// check that writing a minimal size STREAM frame (i.e. with 1 byte data) is actually larger than the desired size
f.Data = []byte{0}
b, err := f.Write(nil, protocol.Version1)
b, err := f.Append(nil, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
Expect(len(b)).To(BeNumerically(">", i))
continue
}
f.Data = data[:int(maxDataLen)]
b, err := f.Write(nil, protocol.Version1)
b, err := f.Append(nil, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
// There's *one* pathological case, where a data length of x can be encoded into 1 byte
// but a data lengths of x+1 needs 2 bytes