From a92bd2bf558ea272de1f6a03c82ace6f1252a9da Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Tue, 21 Jun 2016 18:14:30 +0700 Subject: [PATCH] don't write any timestamps in QUIC 34 ACK frames ref #182 --- frames/ack_frame_new.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/frames/ack_frame_new.go b/frames/ack_frame_new.go index f1aa513b0..8db486d19 100644 --- a/frames/ack_frame_new.go +++ b/frames/ack_frame_new.go @@ -257,9 +257,7 @@ func (f *AckFrameNew) Write(b *bytes.Buffer, version protocol.VersionNumber) err return errors.New("BUG: Inconsistent number of ACK ranges written") } - b.WriteByte(0x01) // Just one timestamp - b.WriteByte(0x00) // Delta Largest observed - utils.WriteUint32(b, 0) // First timestamp + b.WriteByte(0) // no timestamps return nil } @@ -267,7 +265,7 @@ func (f *AckFrameNew) Write(b *bytes.Buffer, version protocol.VersionNumber) err // MinLength of a written frame func (f *AckFrameNew) MinLength(version protocol.VersionNumber) (protocol.ByteCount, error) { var length protocol.ByteCount - length = 1 + 2 + 1 + 1 + 4 // 1 TypeByte, 2 ACK delay time, 1 Num Timestamp, 1 Delta Largest Observed, 4 FirstTimestamp + length = 1 + 2 + 1 // 1 TypeByte, 2 ACK delay time, 1 Num Timestamp length += protocol.ByteCount(protocol.GetPacketNumberLength(f.LargestObserved)) missingSequenceNumberDeltaLen := protocol.ByteCount(protocol.PacketNumberLen6)