gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

don't require the initial_max_stream_id in the transport parameters

Browse Source 
The draft was recently changed to make this value optional.
This commit is contained in:
Marten Seemann
2017-12-05 08:56:49 +07:00
parent ccd91a36b7
commit a72efca38d
2 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/handshake/transport_parameter_test.go
View File

@@ -149,12 +149,6 @@ var _ = Describe("Transport Parameters", func() {
Expect(err).To(MatchError("missing parameter"))
})
It("rejects the parameters if the initial_max_stream_id is missing", func() {
delete(parameters, initialMaxStreamIDParameterID)
_, err := readTransportParamters(paramsMapToList(parameters))
Expect(err).To(MatchError("missing parameter"))
})
It("rejects the parameters if the idle_timeout is missing", func() {
delete(parameters, idleTimeoutParameterID)
_, err := readTransportParamters(paramsMapToList(parameters))

4
internal/handshake/transport_parameters.go
View File

@@ -97,7 +97,6 @@ func readTransportParamters(paramsList []transportParameter) (*TransportParamete
var foundInitialMaxStreamData bool
var foundInitialMaxData bool
var foundInitialMaxStreamID bool
var foundIdleTimeout bool
for _, p := range paramsList {
@@ -115,7 +114,6 @@ func readTransportParamters(paramsList []transportParameter) (*TransportParamete
}
params.ConnectionFlowControlWindow = protocol.ByteCount(binary.BigEndian.Uint32(p.Value))
case initialMaxStreamIDParameterID:
foundInitialMaxStreamID = true
if len(p.Value) != 4 {
return nil, fmt.Errorf("wrong length for initial_max_stream_id: %d (expected 4)", len(p.Value))
}
@@ -134,7 +132,7 @@ func readTransportParamters(paramsList []transportParameter) (*TransportParamete
}
}
if !(foundInitialMaxStreamData && foundInitialMaxData && foundInitialMaxStreamID && foundIdleTimeout) {
if !(foundInitialMaxStreamData && foundInitialMaxData && foundIdleTimeout) {
return nil, errors.New("missing parameter")
}
return params, nil