gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

document what happens to established connections on Listener.Close (#4138)

Browse Source
This commit is contained in:
Marten Seemann
2023-10-28 13:40:50 +07:00
committed by GitHub
parent 6eb0caca1a
commit a3603549ee
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server.go
View File

@@ -133,7 +133,9 @@ func (l *Listener) Accept(ctx context.Context) (Connection, error) {
// Close closes the listener. // Close closes the listener.
// Accept will return ErrServerClosed as soon as all connections in the accept queue have been accepted. // Accept will return ErrServerClosed as soon as all connections in the accept queue have been accepted.
// QUIC handshakes that are still in flight will be rejected with a CONNECTION_REFUSED error. // QUIC handshakes that are still in flight will be rejected with a CONNECTION_REFUSED error.
// Closing the listener doesn't have any effect on already established connections. // The effect of closing the listener depends on how it was created:
// * if it was created using Transport.Listen, already established connections will be unaffected
// * if it was created using the Listen convenience method, all established connection will be closed immediately
func (l *Listener) Close() error { func (l *Listener) Close() error {
return l.baseServer.Close() return l.baseServer.Close()
} }
@@ -216,6 +218,7 @@ func listenUDP(addr string) (*net.UDPConn, error) {
// This is a convenience function. More advanced use cases should instantiate a Transport, // This is a convenience function. More advanced use cases should instantiate a Transport,
// which offers configuration options for a more fine-grained control of the connection establishment, // which offers configuration options for a more fine-grained control of the connection establishment,
// including reusing the underlying UDP socket for outgoing QUIC connections. // including reusing the underlying UDP socket for outgoing QUIC connections.
// When closing a listener created with Listen, all established QUIC connections will be closed immediately.
func Listen(conn net.PacketConn, tlsConf *tls.Config, config *Config) (*Listener, error) { func Listen(conn net.PacketConn, tlsConf *tls.Config, config *Config) (*Listener, error) {
tr := &Transport{Conn: conn, isSingleUse: true} tr := &Transport{Conn: conn, isSingleUse: true}
return tr.Listen(tlsConf, config) return tr.Listen(tlsConf, config)