gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

enable DPLPMTUD on macOS dual-stack sockets (#4723)

Browse Source 
* enable DPLPMTUD on macOS dual-stack sockets

https://datatracker.ietf.org/doc/draft-seemann-tsvwg-udp-fragmentation/
contains details on how IP fragmentation is handled on different
platforms.

* only enable DF on macOS Sequoia (and newer) dual-stack sockets

* fix macOS version numbers

* fix comment in MTU integration test

* skip dual-stack test on old macOS versions
This commit is contained in:
Marten Seemann
2024-12-01 14:50:49 +08:00
committed by GitHub
parent aed4d8df0c
commit a302d7ba4d
4 changed files with 155 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

99
sys_conn_df_darwin_test.go Normal file
View File

@@ -0,0 +1,99 @@
package quic
import (
"net"
"testing"
"github.com/stretchr/testify/require"
)
func TestIPFragmentation(t *testing.T) {
sink, err := net.ListenUDP("udp", &net.UDPAddr{Port: 0})
require.NoError(t, err)
t.Cleanup(func() { sink.Close() })
sinkPort := sink.LocalAddr().(*net.UDPAddr).Port
canSendIPv4 := func(conn *net.UDPConn) bool {
_, err := conn.WriteTo([]byte("hello"), &net.UDPAddr{IP: net.IPv4(127, 0, 0, 1), Port: sinkPort})
return err == nil
}
canSendIPv6 := func(conn *net.UDPConn) bool {
_, err := conn.WriteTo([]byte("hello"), &net.UDPAddr{IP: net.IPv6loopback, Port: sinkPort})
return err == nil
}
t.Run("udp4", func(t *testing.T) {
conn, err := net.ListenUDP("udp4", &net.UDPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 0})
require.NoError(t, err)
defer conn.Close()
require.True(t, canSendIPv4(conn))
require.False(t, canSendIPv6(conn))
raw, err := conn.SyscallConn()
require.NoError(t, err)
canDF, _ := setDF(raw)
require.True(t, canDF)
})
t.Run("udp6", func(t *testing.T) {
conn, err := net.ListenUDP("udp6", &net.UDPAddr{IP: net.IPv6loopback, Port: 0})
require.NoError(t, err)
defer conn.Close()
require.False(t, canSendIPv4(conn))
require.True(t, canSendIPv6(conn))
raw, err := conn.SyscallConn()
require.NoError(t, err)
canDF, _ := setDF(raw)
require.True(t, canDF)
})
t.Run("udp, dual-stack", func(t *testing.T) {
if version, err := getMacOSVersion(); err != nil || version < macOSVersion15 {
t.Skipf("skipping on darwin %d", version-9)
}
conn, err := net.ListenUDP("udp", &net.UDPAddr{Port: 0})
require.NoError(t, err)
defer conn.Close()
require.True(t, canSendIPv4(conn))
require.True(t, canSendIPv6(conn))
raw, err := conn.SyscallConn()
require.NoError(t, err)
canDF, _ := setDF(raw)
require.True(t, canDF)
})
t.Run("udp, listening on IPv4", func(t *testing.T) {
conn, err := net.ListenUDP("udp", &net.UDPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 0})
require.NoError(t, err)
defer conn.Close()
require.True(t, canSendIPv4(conn))
require.False(t, canSendIPv6(conn))
raw, err := conn.SyscallConn()
require.NoError(t, err)
canDF, _ := setDF(raw)
require.True(t, canDF)
})
t.Run("udp, listening on IPv6", func(t *testing.T) {
conn, err := net.ListenUDP("udp6", &net.UDPAddr{IP: net.IPv6loopback, Port: 0})
require.NoError(t, err)
defer conn.Close()
require.False(t, canSendIPv4(conn))
require.True(t, canSendIPv6(conn))
raw, err := conn.SyscallConn()
require.NoError(t, err)
canDF, _ := setDF(raw)
require.True(t, canDF)
})
}