move generation of qtls.Config to a separate file, add tests

internal/handshake/qtls_test.go

@@ -0,0 +1,99 @@
+package handshake
+
+import (
+	"crypto/tls"
+	"errors"
+
+	"github.com/marten-seemann/qtls"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+)
+
+type mockExtensionHandler struct {
+	get, received bool
+}
+
+var _ tlsExtensionHandler = &mockExtensionHandler{}
+
+func (h *mockExtensionHandler) GetExtensions(msgType uint8) []qtls.Extension {
+	h.get = true
+	return nil
+}
+func (h *mockExtensionHandler) ReceivedExtensions(msgType uint8, exts []qtls.Extension) {
+	h.received = true
+}
+func (*mockExtensionHandler) TransportParameters() <-chan []byte { panic("not implemented") }
+
+var _ = Describe("qtls.Config generation", func() {
+	It("sets MinVersion and MaxVersion", func() {
+		tlsConf := &tls.Config{MinVersion: tls.VersionTLS11, MaxVersion: tls.VersionTLS12}
+		qtlsConf := tlsConfigToQtlsConfig(tlsConf, nil, &mockExtensionHandler{})
+		Expect(qtlsConf.MinVersion).To(BeEquivalentTo(tls.VersionTLS13))
+		Expect(qtlsConf.MaxVersion).To(BeEquivalentTo(tls.VersionTLS13))
+	})
+
+	It("works when called with a nil config", func() {
+		qtlsConf := tlsConfigToQtlsConfig(nil, nil, &mockExtensionHandler{})
+		Expect(qtlsConf).ToNot(BeNil())
+	})
+
+	It("sets the setter and getter function for TLS extensions", func() {
+		extHandler := &mockExtensionHandler{}
+		qtlsConf := tlsConfigToQtlsConfig(&tls.Config{}, nil, extHandler)
+		Expect(extHandler.get).To(BeFalse())
+		qtlsConf.GetExtensions(10)
+		Expect(extHandler.get).To(BeTrue())
+		Expect(extHandler.received).To(BeFalse())
+		qtlsConf.ReceivedExtensions(10, nil)
+		Expect(extHandler.received).To(BeTrue())
+	})
+
+	Context("GetConfigForClient callback", func() {
+		It("doesn't set it if absent", func() {
+			qtlsConf := tlsConfigToQtlsConfig(&tls.Config{}, nil, &mockExtensionHandler{})
+			Expect(qtlsConf.GetConfigForClient).To(BeNil())
+		})
+
+		It("returns a qtls.Config", func() {
+			tlsConf := &tls.Config{
+				GetConfigForClient: func(*tls.ClientHelloInfo) (*tls.Config, error) {
+					return &tls.Config{ServerName: "foo.bar"}, nil
+				},
+			}
+			extHandler := &mockExtensionHandler{}
+			qtlsConf := tlsConfigToQtlsConfig(tlsConf, nil, extHandler)
+			Expect(qtlsConf.GetConfigForClient).ToNot(BeNil())
+			confForClient, err := qtlsConf.GetConfigForClient(nil)
+			Expect(err).ToNot(HaveOccurred())
+			Expect(confForClient.ServerName).To(Equal("foo.bar"))
+			Expect(confForClient).ToNot(BeNil())
+			Expect(confForClient.MinVersion).To(BeEquivalentTo(tls.VersionTLS13))
+			Expect(confForClient.MaxVersion).To(BeEquivalentTo(tls.VersionTLS13))
+			Expect(extHandler.get).To(BeFalse())
+			confForClient.GetExtensions(10)
+			Expect(extHandler.get).To(BeTrue())
+		})
+
+		It("returns errors", func() {
+			testErr := errors.New("test")
+			tlsConf := &tls.Config{
+				GetConfigForClient: func(*tls.ClientHelloInfo) (*tls.Config, error) {
+					return nil, testErr
+				},
+			}
+			qtlsConf := tlsConfigToQtlsConfig(tlsConf, nil, &mockExtensionHandler{})
+			_, err := qtlsConf.GetConfigForClient(nil)
+			Expect(err).To(MatchError(testErr))
+		})
+
+		It("returns nil when the callback returns nil", func() {
+			tlsConf := &tls.Config{
+				GetConfigForClient: func(*tls.ClientHelloInfo) (*tls.Config, error) {
+					return nil, nil
+				},
+			}
+			qtlsConf := tlsConfigToQtlsConfig(tlsConf, nil, &mockExtensionHandler{})
+			Expect(qtlsConf.GetConfigForClient(nil)).To(BeNil())
+		})
+	})
+})