gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

Merge pull request #1361 from lucas-clemente/dont-trust-unauthenticated-packets

Browse Source 
don't save anything about a packet before authenticating it
This commit is contained in:
Marten Seemann
2018-05-29 16:34:53 +08:00
committed by GitHub
parent fd906aeb24 bd483c75e5
commit 993e282ed2
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
session.go
View File

@@ -603,9 +603,6 @@ func (s *session) handlePacketImpl(p *receivedPacket) error {
p.rcvTime = time.Now() p.rcvTime = time.Now()
} }
s.receivedFirstPacket = true
s.lastNetworkActivityTime = p.rcvTime
s.keepAlivePingSent = false
hdr := p.header hdr := p.header
data := p.data data := p.data
@@ -630,6 +627,10 @@ func (s *session) handlePacketImpl(p *receivedPacket) error {
return err return err
} }
s.receivedFirstPacket = true
s.lastNetworkActivityTime = p.rcvTime
s.keepAlivePingSent = false
// In TLS 1.3, the client considers the handshake complete as soon as // In TLS 1.3, the client considers the handshake complete as soon as
// it received the server's Finished message and sent its Finished. // it received the server's Finished message and sent its Finished.
// We have to wait for the first forward-secure packet from the server before // We have to wait for the first forward-secure packet from the server before