From 98c437e98e7641cdaba0181cff1ea31050989273 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Fri, 25 Sep 2020 17:11:22 +0700 Subject: [PATCH] fail the handshake if the quic_transport_parameter extension is missing --- internal/handshake/crypto_setup.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/handshake/crypto_setup.go b/internal/handshake/crypto_setup.go index 7e0bb99a9..2d7826cb5 100644 --- a/internal/handshake/crypto_setup.go +++ b/internal/handshake/crypto_setup.go @@ -341,7 +341,11 @@ readLoop: for { select { case data := <-h.paramsChan: - h.handleTransportParameters(data) + if data == nil { + h.onError(0x6d, "missing quic_transport_parameters extension") + } else { + h.handleTransportParameters(data) + } case <-h.isReadingHandshakeMessage: break readLoop case <-h.handshakeDone: