gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove unneeded version constant in wire tests

Browse Source
This commit is contained in:
Marten Seemann
2022-05-25 15:38:17 +02:00
parent f10d4bd8f7
commit 909a3a9093
19 changed files with 225 additions and 229 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
internal/wire/retire_connection_id_frame_test.go
View File

@@ -4,6 +4,8 @@ import (
"bytes"
"io"
"github.com/lucas-clemente/quic-go/internal/protocol"
. "github.com/onsi/ginkgo"
. "github.com/onsi/gomega"
)
@@ -14,7 +16,7 @@ var _ = Describe("NEW_CONNECTION_ID frame", func() {
data := []byte{0x19}
data = append(data, encodeVarInt(0xdeadbeef)...) // sequence number
b := bytes.NewReader(data)
frame, err := parseRetireConnectionIDFrame(b, versionIETFFrames)
frame, err := parseRetireConnectionIDFrame(b, protocol.Version1)
Expect(err).ToNot(HaveOccurred())
Expect(frame.SequenceNumber).To(Equal(uint64(0xdeadbeef)))
})
@@ -22,10 +24,10 @@ var _ = Describe("NEW_CONNECTION_ID frame", func() {
It("errors on EOFs", func() {
data := []byte{0x18}
data = append(data, encodeVarInt(0xdeadbeef)...) // sequence number
_, err := parseRetireConnectionIDFrame(bytes.NewReader(data), versionIETFFrames)
_, err := parseRetireConnectionIDFrame(bytes.NewReader(data), protocol.Version1)
Expect(err).NotTo(HaveOccurred())
for i := range data {
_, err := parseRetireConnectionIDFrame(bytes.NewReader(data[0:i]), versionIETFFrames)
_, err := parseRetireConnectionIDFrame(bytes.NewReader(data[0:i]), protocol.Version1)
Expect(err).To(MatchError(io.EOF))
}
})
@@ -35,7 +37,7 @@ var _ = Describe("NEW_CONNECTION_ID frame", func() {
It("writes a sample frame", func() {
frame := &RetireConnectionIDFrame{SequenceNumber: 0x1337}
b := &bytes.Buffer{}
Expect(frame.Write(b, versionIETFFrames)).To(Succeed())
Expect(frame.Write(b, protocol.Version1)).To(Succeed())
expected := []byte{0x19}
expected = append(expected, encodeVarInt(0x1337)...)
Expect(b.Bytes()).To(Equal(expected))
@@ -44,8 +46,8 @@ var _ = Describe("NEW_CONNECTION_ID frame", func() {
It("has the correct length", func() {
frame := &RetireConnectionIDFrame{SequenceNumber: 0xdecafbad}
b := &bytes.Buffer{}
Expect(frame.Write(b, versionIETFFrames)).To(Succeed())
Expect(frame.Length(versionIETFFrames)).To(BeEquivalentTo(b.Len()))
Expect(frame.Write(b, protocol.Version1)).To(Succeed())
Expect(frame.Length(protocol.Version1)).To(BeEquivalentTo(b.Len()))
})
})
})