gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix receive flow control windows diverging

Browse Source
This commit is contained in:
Lucas Clemente
2016-08-01 14:19:45 +02:00
parent 0d8cd978a7
commit 8a9f5f9833
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
flowcontrol/flow_controller.go
View File

@@ -102,8 +102,8 @@ func (c *flowController) MaybeTriggerWindowUpdate() (bool, protocol.ByteCount) {
diff := c.receiveFlowControlWindow - c.bytesRead diff := c.receiveFlowControlWindow - c.bytesRead
// Chromium implements the same threshold // Chromium implements the same threshold
if diff < (c.receiveFlowControlWindowIncrement / 2) { if diff < (c.receiveFlowControlWindowIncrement / 2) {
c.receiveFlowControlWindow += c.receiveFlowControlWindowIncrement c.receiveFlowControlWindow = c.bytesRead + c.receiveFlowControlWindowIncrement
return true, c.bytesRead + c.receiveFlowControlWindowIncrement return true, c.receiveFlowControlWindow
} }
return false, 0 return false, 0
} }

1
flowcontrol/flow_controller_test.go
View File

@@ -154,6 +154,7 @@ var _ = Describe("Flow controller", func() {
updateNecessary, offset := controller.MaybeTriggerWindowUpdate() updateNecessary, offset := controller.MaybeTriggerWindowUpdate()
Expect(updateNecessary).To(BeTrue()) Expect(updateNecessary).To(BeTrue())
Expect(offset).To(Equal(readPosition + receiveFlowControlWindowIncrement)) Expect(offset).To(Equal(readPosition + receiveFlowControlWindowIncrement))
Expect(controller.receiveFlowControlWindow).To(Equal(readPosition + receiveFlowControlWindowIncrement))
}) })
It("triggers a window update when not necessary", func() { It("triggers a window update when not necessary", func() {