gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

respect connection flow control window in StreamFrameQueue

Browse Source
This commit is contained in:
Marten Seemann
2016-06-16 16:00:18 +07:00
committed by Lucas Clemente
parent 1b732a4afa
commit 8a9d70488a
3 changed files with 50 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
stream_frame_queue_test.go
View File

@@ -406,7 +406,7 @@ var _ = Describe("streamFrameQueue", func() {
Expect(frame.DataLen()).To(Equal(protocol.ByteCount(len)))
})
It("returns a split frame if the whole frame doesn't fit, for non-zero StreamFrame offset", func() {
It("returns a split frame if the whole frame doesn't fit in the stream flow control window, for non-zero StreamFrame offset", func() {
frame1.Offset = 2
queue.Push(frame1, false)
queue.flowControlManager.(*mockFlowControlHandler).sendWindowSizes[frame1.StreamID] = 4
@@ -415,6 +415,16 @@ var _ = Describe("streamFrameQueue", func() {
Expect(frame.DataLen()).To(Equal(protocol.ByteCount(2)))
})
It("returns a split frame if the whole frame doesn't fit in the connection flow control window", func() {
frame1.Offset = 2
queue.Push(frame1, false)
queue.flowControlManager.(*mockFlowControlHandler).streamsContributing = []protocol.StreamID{frame1.StreamID}
queue.flowControlManager.(*mockFlowControlHandler).remainingConnectionWindowSize = 3
frame, err := queue.Pop(1000)
Expect(err).ToNot(HaveOccurred())
Expect(frame.DataLen()).To(Equal(protocol.ByteCount(3)))
})
It("skips a frame if the stream is flow control blocked", func() {
queue.flowControlManager.(*mockFlowControlHandler).sendWindowSizes[frame1.StreamID] = 0
queue.Push(frame1, false)
@@ -424,6 +434,17 @@ var _ = Describe("streamFrameQueue", func() {
Expect(frame).To(Equal(frame2))
})
It("skips a frame if the connection is flow control blocked", func() {
queue.flowControlManager.(*mockFlowControlHandler).sendWindowSizes[frame1.StreamID] = 10000
queue.flowControlManager.(*mockFlowControlHandler).streamsContributing = []protocol.StreamID{frame1.StreamID}
queue.flowControlManager.(*mockFlowControlHandler).remainingConnectionWindowSize = 0
queue.Push(frame1, false)
queue.Push(frame2, false)
frame, err := queue.Pop(1000)
Expect(err).ToNot(HaveOccurred())
Expect(frame).To(Equal(frame2))
})
It("returns nil if no stream is not flow control blocked", func() {
queue.flowControlManager.(*mockFlowControlHandler).sendWindowSizes[frame1.StreamID] = 0
queue.flowControlManager.(*mockFlowControlHandler).sendWindowSizes[frame2.StreamID] = 0