gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove the SkipSchemeCheck RoundTripOpt (#3353)

Browse Source 
This option was needed for an early draft version of MASQUE.
MASQUE now uses the https scheme.
This commit is contained in:
Marten Seemann
2022-03-25 09:38:17 +01:00
committed by GitHub
parent 3a102406ea
commit 85b495445e
2 changed files with 2 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
http3/roundtrip_test.go
View File

@@ -179,15 +179,6 @@ var _ = Describe("RoundTripper", func() {
Expect(req.Body.(*mockBody).closed).To(BeTrue())
})
It("allow non-https schemes if SkipSchemeCheck is set", func() {
req, err := http.NewRequest("GET", "masque://www.example.org/", nil)
Expect(err).ToNot(HaveOccurred())
_, err = rt.RoundTrip(req)
Expect(err).To(MatchError("http3: unsupported protocol scheme: masque"))
_, err = rt.RoundTripOpt(req, RoundTripOpt{SkipSchemeCheck: true, OnlyCachedConn: true})
Expect(err).To(MatchError("http3: no cached connection was available"))
})
It("rejects requests without a URL", func() {
req1.URL = nil
req1.Body = &mockBody{}