gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix DOS against ReceivedPacketHandler garbage collector

Browse Source 
fixes #334
This commit is contained in:
Marten Seemann
2016-10-27 23:30:57 +07:00
parent 2e7fb25672
commit 7cf68d50db
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
ackhandler/received_packet_handler_test.go
View File

@@ -310,5 +310,16 @@ var _ = Describe("receivedPacketHandler", func() {
Expect(handler.receivedTimes).To(HaveKey(protocol.PacketNumber(4)))
Expect(handler.lowestInReceivedTimes).To(Equal(protocol.PacketNumber(4)))
})
// this prevents a DOS where a client sends us an unreasonably high LeastUnacked value
It("does not garbage collect packets higher than the LargestObserved packet number", func() {
err := handler.ReceivedPacket(10)
Expect(err).ToNot(HaveOccurred())
handler.largestObserved = 5
err = handler.ReceivedStopWaiting(&frames.StopWaitingFrame{LeastUnacked: 20})
Expect(err).ToNot(HaveOccurred())
Expect(handler.receivedTimes).To(HaveKey(protocol.PacketNumber(10)))
Expect(handler.lowestInReceivedTimes).To(Equal(protocol.PacketNumber(20)))
})
})
})