gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

utils: remove unused methods and constructor from RTTStats (#4672)

Browse Source
This commit is contained in:
Marten Seemann
2024-09-12 15:55:57 +08:00
committed by GitHub
parent 5247a8ee42
commit 7a10ed602d
9 changed files with 60 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
qlog/connection_tracer_test.go
View File

@@ -606,17 +606,12 @@ func TestDroppedPacketWithPacketNumber(t *testing.T) {
func TestUpdatedMetrics(t *testing.T) {
now := time.Now()
rttStats := utils.NewRTTStats()
var rttStats utils.RTTStats
rttStats.UpdateRTT(15*time.Millisecond, 0, now)
rttStats.UpdateRTT(20*time.Millisecond, 0, now)
rttStats.UpdateRTT(25*time.Millisecond, 0, now)
tracer, buf := newConnectionTracer()
tracer.UpdatedMetrics(
rttStats,
4321,
1234,
42,
)
tracer.UpdatedMetrics(&rttStats, 4321, 1234, 42)
tracer.Close()
entry := exportAndParseSingle(t, buf)
require.WithinDuration(t, time.Now(), entry.Time, scaleDuration(10*time.Millisecond))
@@ -635,29 +630,19 @@ func TestUpdatedMetrics(t *testing.T) {
func TestDiffForOnlyChangedMetrics(t *testing.T) {
now := time.Now()
rttStats := utils.NewRTTStats()
var rttStats utils.RTTStats
rttStats.UpdateRTT(15*time.Millisecond, 0, now)
rttStats.UpdateRTT(20*time.Millisecond, 0, now)
rttStats.UpdateRTT(25*time.Millisecond, 0, now)
rttStats2 := utils.NewRTTStats()
var rttStats2 utils.RTTStats
rttStats2.UpdateRTT(15*time.Millisecond, 0, now)
rttStats2.UpdateRTT(15*time.Millisecond, 0, now)
rttStats2.UpdateRTT(15*time.Millisecond, 0, now)
tracer, buf := newConnectionTracer()
tracer.UpdatedMetrics(
rttStats,
4321,
1234,
42,
)
tracer.UpdatedMetrics(
rttStats2,
4321,
12345, // changed
42,
)
tracer.UpdatedMetrics(&rttStats, 4321, 1234, 42)
tracer.UpdatedMetrics(&rttStats2, 4321, 12345 /* changed */, 42)
tracer.Close()
entries := exportAndParse(t, buf)
require.Len(t, entries, 2)