From 19ddefd1d99bbcda0ad918cae8670e332e6bbb4b Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Fri, 18 Dec 2020 12:16:07 +0700 Subject: [PATCH] remove unneeded check for the peer's transport parameters We create a new flow controller when opening a new streams. This can only happen after the session is returned, in which case we should have already received the transport parameters. --- session.go | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/session.go b/session.go index a1994b1ab..259f52fe7 100644 --- a/session.go +++ b/session.go @@ -1681,16 +1681,12 @@ func (s *session) OpenUniStreamSync(ctx context.Context) (SendStream, error) { } func (s *session) newFlowController(id protocol.StreamID) flowcontrol.StreamFlowController { - var initialSendWindow protocol.ByteCount - if s.peerParams != nil { - if id.Type() == protocol.StreamTypeUni { - initialSendWindow = s.peerParams.InitialMaxStreamDataUni + initialSendWindow := s.peerParams.InitialMaxStreamDataUni + if id.Type() == protocol.StreamTypeBidi { + if id.InitiatedBy() == s.perspective { + initialSendWindow = s.peerParams.InitialMaxStreamDataBidiRemote } else { - if id.InitiatedBy() == s.perspective { - initialSendWindow = s.peerParams.InitialMaxStreamDataBidiRemote - } else { - initialSendWindow = s.peerParams.InitialMaxStreamDataBidiLocal - } + initialSendWindow = s.peerParams.InitialMaxStreamDataBidiLocal } } return flowcontrol.NewStreamFlowController(