From 788b6f44095a8386145bca93b9cc0c5d02674d2e Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Wed, 17 Apr 2024 09:44:20 -0700 Subject: [PATCH] http3: fix flaky RoundTripper test (#4442) --- http3/roundtrip_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/http3/roundtrip_test.go b/http3/roundtrip_test.go index f3ff1e559..fd8583b99 100644 --- a/http3/roundtrip_test.go +++ b/http3/roundtrip_test.go @@ -277,14 +277,15 @@ var _ = Describe("RoundTripper", func() { Expect(err).ToNot(HaveOccurred()) conn := mockquic.NewMockEarlyConnection(mockCtrl) - handshakeChan := make(chan struct{}) - close(handshakeChan) var count int rt.Dial = func(context.Context, string, *tls.Config, *quic.Config) (quic.EarlyConnection, error) { count++ return conn, nil } testErr := errors.New("test err") + handshakeChan := make(chan struct{}) + close(handshakeChan) + conn.EXPECT().HandshakeComplete().Return(handshakeChan).MaxTimes(2) cl1.EXPECT().RoundTripOpt(req1, gomock.Any()).Return(nil, testErr) cl2.EXPECT().RoundTripOpt(req2, gomock.Any()).Return(&http.Response{Request: req2}, nil) _, err = rt.RoundTrip(req1)