gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix flaky session tests

Browse Source 
ref #83
This commit is contained in:
Lucas Clemente
2016-07-08 15:29:10 +02:00
parent 50aa7ec52c
commit 66594f7a8a
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
session_test.go
View File

@@ -550,8 +550,8 @@ var _ = Describe("Session", func() {
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
_, err = s.Write([]byte("foobar2")) _, err = s.Write([]byte("foobar2"))
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
time.Sleep(10 * time.Millisecond) Eventually(func() [][]byte { return conn.written }).Should(HaveLen(1))
Expect(conn.written).To(HaveLen(1)) Consistently(func() [][]byte { return conn.written }).Should(HaveLen(1))
}) })
It("sends out two big frames in two packets", func() { It("sends out two big frames in two packets", func() {
@@ -567,8 +567,7 @@ var _ = Describe("Session", func() {
}() }()
_, err = s2.Write(bytes.Repeat([]byte{'e'}, int(protocol.SmallPacketPayloadSizeThreshold+50))) _, err = s2.Write(bytes.Repeat([]byte{'e'}, int(protocol.SmallPacketPayloadSizeThreshold+50)))
Expect(err).ToNot(HaveOccurred()) Expect(err).ToNot(HaveOccurred())
time.Sleep(10 * time.Millisecond) Eventually(func() [][]byte { return conn.written }).Should(HaveLen(2))
Eventually(conn.written).Should(HaveLen(2))
}) })
It("sends out two small frames that are written to long after one another into two packets", func() { It("sends out two small frames that are written to long after one another into two packets", func() {
@@ -577,10 +576,10 @@ var _ = Describe("Session", func() {
go session.run() go session.run()
_, err = s.Write([]byte("foobar1")) _, err = s.Write([]byte("foobar1"))
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
Expect(conn.written).To(HaveLen(1)) Eventually(func() [][]byte { return conn.written }).Should(HaveLen(1))
_, err = s.Write([]byte("foobar2")) _, err = s.Write([]byte("foobar2"))
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
Expect(conn.written).To(HaveLen(2)) Eventually(func() [][]byte { return conn.written }).Should(HaveLen(2))
}) })
It("sends a queued ACK frame only once", func() { It("sends a queued ACK frame only once", func() {
@@ -592,11 +591,11 @@ var _ = Describe("Session", func() {
go session.run() go session.run()
_, err = s.Write([]byte("foobar1")) _, err = s.Write([]byte("foobar1"))
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
Expect(conn.written).To(HaveLen(1)) Eventually(func() [][]byte { return conn.written }).Should(HaveLen(1))
_, err = s.Write([]byte("foobar2")) _, err = s.Write([]byte("foobar2"))
Expect(err).NotTo(HaveOccurred()) Expect(err).NotTo(HaveOccurred())
Expect(conn.written).To(HaveLen(2)) Eventually(func() [][]byte { return conn.written }).Should(HaveLen(2))
Expect(conn.written[0]).To(ContainSubstring(string([]byte{0x37, 0x13}))) Expect(conn.written[0]).To(ContainSubstring(string([]byte{0x37, 0x13})))
Expect(conn.written[1]).ToNot(ContainSubstring(string([]byte{0x37, 0x13}))) Expect(conn.written[1]).ToNot(ContainSubstring(string([]byte{0x37, 0x13})))
}) })