gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix a race condition in session.handleWindowUpdateFrame

Browse Source
This commit is contained in:
Lucas Clemente
2016-06-06 23:36:48 +02:00
parent ed43ee7bd7
commit 6475a5bb3e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
session.go
View File

@@ -336,6 +336,7 @@ func (s *Session) handleWindowUpdateFrame(frame *frames.WindowUpdateFrame) error
s.streamsMutex.RUnlock() s.streamsMutex.RUnlock()
} else { } else {
s.streamsMutex.RLock() s.streamsMutex.RLock()
defer s.streamsMutex.RUnlock()
stream, streamExists := s.streams[frame.StreamID] stream, streamExists := s.streams[frame.StreamID]
if !streamExists { if !streamExists {
return errWindowUpdateOnInvalidStream return errWindowUpdateOnInvalidStream
@@ -343,7 +344,6 @@ func (s *Session) handleWindowUpdateFrame(frame *frames.WindowUpdateFrame) error
if stream == nil { if stream == nil {
return errWindowUpdateOnClosedStream return errWindowUpdateOnClosedStream
} }
s.streamsMutex.RUnlock()
updated := stream.UpdateSendFlowControlWindow(frame.ByteOffset) updated := stream.UpdateSendFlowControlWindow(frame.ByteOffset)
if updated { if updated {