Merge pull request #2817 from lucas-clemente/qlog-key-phase-bit

qlog the key phase bit

internal/protocol/key_phase.go

@@ -3,23 +3,34 @@ package protocol
 // KeyPhase is the key phase
 type KeyPhase uint64
 
+// Bit determines the key phase bit
 func (p KeyPhase) Bit() KeyPhaseBit {
-	return p%2 == 1
+	if p%2 == 0 {
+		return KeyPhaseZero
+	}
+	return KeyPhaseOne
 }
 
 // KeyPhaseBit is the key phase bit
-type KeyPhaseBit bool
+type KeyPhaseBit uint8
 
 const (
+	// KeyPhaseUndefined is an undefined key phase
+	KeyPhaseUndefined KeyPhaseBit = iota
 	// KeyPhaseZero is key phase 0
-	KeyPhaseZero KeyPhaseBit = false
+	KeyPhaseZero
 	// KeyPhaseOne is key phase 1
-	KeyPhaseOne KeyPhaseBit = true
+	KeyPhaseOne
 )
 
 func (p KeyPhaseBit) String() string {
-	if p == KeyPhaseZero {
+	//nolint:exhaustive
+	switch p {
+	case KeyPhaseZero:
 		return "0"
+	case KeyPhaseOne:
+		return "1"
+	default:
+		return "undefined"
 	}
-	return "1"
 }

internal/protocol/key_phase_test.go

@@ -6,6 +6,11 @@ import (
 )
 
 var _ = Describe("Key Phases", func() {
+	It("has undefined as its default value", func() {
+		var k KeyPhaseBit
+		Expect(k).To(Equal(KeyPhaseUndefined))
+	})
+
 	It("has the correct string representation", func() {
 		Expect(KeyPhaseZero.String()).To(Equal("0"))
 		Expect(KeyPhaseOne.String()).To(Equal("1"))