gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove unused version parameter form the connIDGenerator

Browse Source
This commit is contained in:
Marten Seemann
2022-12-24 12:18:00 +13:00
parent 3affa1d911
commit 5c7d120b8f
3 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
conn_id_generator.go
View File

@@ -22,8 +22,6 @@ type connIDGenerator struct {
retireConnectionID func(protocol.ConnectionID) retireConnectionID func(protocol.ConnectionID)
replaceWithClosed func([]protocol.ConnectionID, protocol.Perspective, []byte) replaceWithClosed func([]protocol.ConnectionID, protocol.Perspective, []byte)
queueControlFrame func(wire.Frame) queueControlFrame func(wire.Frame)
version protocol.VersionNumber
} }
func newConnIDGenerator( func newConnIDGenerator(
@@ -36,7 +34,6 @@ func newConnIDGenerator(
replaceWithClosed func([]protocol.ConnectionID, protocol.Perspective, []byte), replaceWithClosed func([]protocol.ConnectionID, protocol.Perspective, []byte),
queueControlFrame func(wire.Frame), queueControlFrame func(wire.Frame),
generator ConnectionIDGenerator, generator ConnectionIDGenerator,
version protocol.VersionNumber,
) *connIDGenerator { ) *connIDGenerator {
m := &connIDGenerator{ m := &connIDGenerator{
generator: generator, generator: generator,
@@ -47,7 +44,6 @@ func newConnIDGenerator(
retireConnectionID: retireConnectionID, retireConnectionID: retireConnectionID,
replaceWithClosed: replaceWithClosed, replaceWithClosed: replaceWithClosed,
queueControlFrame: queueControlFrame, queueControlFrame: queueControlFrame,
version: version,
} }
m.activeSrcConnIDs[0] = initialConnectionID m.activeSrcConnIDs[0] = initialConnectionID
m.initialClientDestConnID = initialClientDestConnID m.initialClientDestConnID = initialClientDestConnID

1
conn_id_generator_test.go
View File

@@ -46,7 +46,6 @@ var _ = Describe("Connection ID Generator", func() {
}, },
func(f wire.Frame) { queuedFrames = append(queuedFrames, f) }, func(f wire.Frame) { queuedFrames = append(queuedFrames, f) },
&protocol.DefaultConnectionIDGenerator{ConnLen: initialConnID.Len()}, &protocol.DefaultConnectionIDGenerator{ConnLen: initialConnID.Len()},
protocol.VersionDraft29,
) )
}) })

2
connection.go
View File

@@ -284,7 +284,6 @@ var newConnection = func(
runner.ReplaceWithClosed, runner.ReplaceWithClosed,
s.queueControlFrame, s.queueControlFrame,
s.config.ConnectionIDGenerator, s.config.ConnectionIDGenerator,
s.version,
) )
s.preSetup() s.preSetup()
s.ctx, s.ctxCancel = context.WithCancel(context.WithValue(context.Background(), ConnectionTracingKey, tracingID)) s.ctx, s.ctxCancel = context.WithCancel(context.WithValue(context.Background(), ConnectionTracingKey, tracingID))
@@ -418,7 +417,6 @@ var newClientConnection = func(
runner.ReplaceWithClosed, runner.ReplaceWithClosed,
s.queueControlFrame, s.queueControlFrame,
s.config.ConnectionIDGenerator, s.config.ConnectionIDGenerator,
s.version,
) )
s.preSetup() s.preSetup()
s.ctx, s.ctxCancel = context.WithCancel(context.WithValue(context.Background(), ConnectionTracingKey, tracingID)) s.ctx, s.ctxCancel = context.WithCancel(context.WithValue(context.Background(), ConnectionTracingKey, tracingID))