gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix flaky TestServerTransportClose (#5407)

Browse Source 
* Initial plan

* Fix TestServerTransportClose race condition by accepting conn1 before dialing conn2

Co-authored-by: marten-seemann <1478487+marten-seemann@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: marten-seemann <1478487+marten-seemann@users.noreply.github.com>
This commit is contained in:
Copilot
2025-10-24 18:24:01 +02:00
committed by GitHub
parent 9a7936d2ca
commit 57f5dcb28f
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
integrationtests/self/handshake_test.go
View File

@@ -764,6 +764,11 @@ func TestServerTransportClose(t *testing.T) {
getQuicConfig(&quic.Config{MaxIdleTimeout: scaleDuration(50 * time.Millisecond)}), getQuicConfig(&quic.Config{MaxIdleTimeout: scaleDuration(50 * time.Millisecond)}),
) )
require.NoError(t, err) require.NoError(t, err)
sconn, err := server.Accept(ctx)
require.NoError(t, err)
require.Equal(t, conn1.LocalAddr(), sconn.RemoteAddr())
// ...the second conn isn't, it remains in the server's accept queue // ...the second conn isn't, it remains in the server's accept queue
conn2, err := quic.Dial( conn2, err := quic.Dial(
ctx, ctx,
@@ -776,10 +781,6 @@ func TestServerTransportClose(t *testing.T) {
time.Sleep(scaleDuration(10 * time.Millisecond)) time.Sleep(scaleDuration(10 * time.Millisecond))
sconn, err := server.Accept(ctx)
require.NoError(t, err)
require.Equal(t, conn1.LocalAddr(), sconn.RemoteAddr())
// closing the Transport abruptly terminates connections // closing the Transport abruptly terminates connections
require.NoError(t, tr.Close()) require.NoError(t, tr.Close())