From 57b6c23947a0222bc74750122116fbb2cc947ee1 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sat, 23 Nov 2019 10:47:00 +0700 Subject: [PATCH] only log skipped packet numbers if we actually sent something before After a Retry, we would log the skipping of packet number 0, although it was not actually skipped. We just had reset the packet number space. --- internal/ackhandler/sent_packet_handler.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/ackhandler/sent_packet_handler.go b/internal/ackhandler/sent_packet_handler.go index 3bbee31fe..679bc5d36 100644 --- a/internal/ackhandler/sent_packet_handler.go +++ b/internal/ackhandler/sent_packet_handler.go @@ -145,7 +145,7 @@ func (h *sentPacketHandler) getPacketNumberSpace(encLevel protocol.EncryptionLev func (h *sentPacketHandler) sentPacketImpl(packet *Packet) bool /* is ack-eliciting */ { pnSpace := h.getPacketNumberSpace(packet.EncryptionLevel) - if h.logger.Debug() { + if h.logger.Debug() && pnSpace.history.HasOutstandingPackets() { for p := utils.MaxPacketNumber(0, pnSpace.largestSent+1); p < packet.PacketNumber; p++ { h.logger.Debugf("Skipping packet number %#x", p) }