gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

cosmetic changes in tests

Browse Source
This commit is contained in:
Marten Seemann
2016-05-15 13:08:56 +07:00
parent 0d29bdc499
commit 540941117e
9 changed files with 58 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ackhandler/packet_test.go
View File

@@ -51,14 +51,14 @@ var _ = Describe("Packet", func() {
It("gets all StreamFrames", func() {
streamFrames := packet.GetStreamFramesForRetransmission()
Expect(len(streamFrames)).To(Equal(2))
Expect(streamFrames).To(HaveLen(2))
Expect(streamFrames).To(ContainElement(streamFrame1))
Expect(streamFrames).To(ContainElement(streamFrame2))
})
It("gets all control frames", func() {
controlFrames := packet.GetControlFramesForRetransmission()
Expect(len(controlFrames)).To(Equal(2))
Expect(controlFrames).To(HaveLen(2))
Expect(controlFrames).To(ContainElement(rstStreamFrame))
Expect(controlFrames).To(ContainElement(windowUpdateFrame))
})
@@ -81,7 +81,7 @@ var _ = Describe("Packet", func() {
Frames: []frames.Frame{ackFrame1, rstStreamFrame},
}
streamFrames := packet.GetStreamFramesForRetransmission()
Expect(len(streamFrames)).To(Equal(0))
Expect(streamFrames).To(BeEmpty())
})
It("returns an empty slice of control frames if no applicable control frames are queued", func() {
@@ -91,7 +91,7 @@ var _ = Describe("Packet", func() {
Frames: []frames.Frame{streamFrame1, ackFrame1, stopWaitingFrame},
}
controlFrames := packet.GetControlFramesForRetransmission()
Expect(len(controlFrames)).To(Equal(0))
Expect(controlFrames).To(BeEmpty())
})
})
})

16
ackhandler/received_packet_handler_test.go
View File

@@ -116,7 +116,7 @@ var _ = Describe("receivedPacketHandler", func() {
Expect(handler.largestObserved).To(Equal(protocol.PacketNumber(99)))
Expect(handler.highestInOrderObserved).To(Equal(protocol.PacketNumber(99)))
nackRanges, entropy := handler.getNackRanges()
Expect(len(nackRanges)).To(Equal(0))
Expect(nackRanges).To(BeEmpty())
Expect(entropy).To(Equal(expectedEntropy))
})
@@ -132,7 +132,7 @@ var _ = Describe("receivedPacketHandler", func() {
}
Expect(handler.largestObserved).To(Equal(protocol.PacketNumber(9)))
nackRanges, entropy := handler.getNackRanges()
Expect(len(nackRanges)).To(Equal(1))
Expect(nackRanges).To(HaveLen(1))
Expect(nackRanges[0]).To(Equal(frames.NackRange{FirstPacketNumber: 5, LastPacketNumber: 5}))
Expect(handler.highestInOrderObserved).To(Equal(protocol.PacketNumber(4)))
Expect(entropy).To(Equal(expectedEntropy))
@@ -153,7 +153,7 @@ var _ = Describe("receivedPacketHandler", func() {
}
Expect(handler.largestObserved).To(Equal(protocol.PacketNumber(11)))
nackRanges, entropy := handler.getNackRanges()
Expect(len(nackRanges)).To(Equal(1))
Expect(nackRanges).To(HaveLen(1))
Expect(nackRanges[0]).To(Equal(frames.NackRange{FirstPacketNumber: 5, LastPacketNumber: 6}))
Expect(handler.highestInOrderObserved).To(Equal(protocol.PacketNumber(4)))
Expect(entropy).To(Equal(expectedEntropy))
@@ -174,7 +174,7 @@ var _ = Describe("receivedPacketHandler", func() {
}
Expect(handler.largestObserved).To(Equal(protocol.PacketNumber(9)))
nackRanges, entropy := handler.getNackRanges()
Expect(len(nackRanges)).To(Equal(2))
Expect(nackRanges).To(HaveLen(2))
Expect(nackRanges[0]).To(Equal(frames.NackRange{FirstPacketNumber: 7, LastPacketNumber: 7}))
Expect(nackRanges[1]).To(Equal(frames.NackRange{FirstPacketNumber: 3, LastPacketNumber: 3}))
Expect(handler.highestInOrderObserved).To(Equal(protocol.PacketNumber(2)))
@@ -193,7 +193,7 @@ var _ = Describe("receivedPacketHandler", func() {
}
Expect(handler.largestObserved).To(Equal(protocol.PacketNumber(9)))
nackRanges, entropy := handler.getNackRanges()
Expect(len(nackRanges)).To(Equal(2))
Expect(nackRanges).To(HaveLen(2))
Expect(nackRanges[0]).To(Equal(frames.NackRange{FirstPacketNumber: 7, LastPacketNumber: 8}))
Expect(nackRanges[1]).To(Equal(frames.NackRange{FirstPacketNumber: 2, LastPacketNumber: 4}))
Expect(handler.highestInOrderObserved).To(Equal(protocol.PacketNumber(1)))
@@ -236,7 +236,7 @@ var _ = Describe("receivedPacketHandler", func() {
err = handler.ReceivedStopWaiting(&frames.StopWaitingFrame{Entropy: 0, LeastUnacked: protocol.PacketNumber(10)})
Expect(err).ToNot(HaveOccurred())
ranges, _ = handler.getNackRanges()
Expect(ranges).To(HaveLen(0))
Expect(ranges).To(BeEmpty())
})
})
@@ -329,12 +329,12 @@ var _ = Describe("receivedPacketHandler", func() {
Expect(err).ToNot(HaveOccurred())
ack, _ := handler.GetAckFrame(true)
Expect(ack).ToNot(BeNil())
Expect(len(ack.NackRanges)).To(Equal(1))
Expect(ack.NackRanges).To(HaveLen(1))
err = handler.ReceivedPacket(protocol.PacketNumber(2), false)
Expect(err).ToNot(HaveOccurred())
ack, _ = handler.GetAckFrame(true)
Expect(ack).ToNot(BeNil())
Expect(len(ack.NackRanges)).To(Equal(0))
Expect(ack.NackRanges).To(BeEmpty())
})
})
})

6
ackhandler/sent_packet_handler_test.go
View File

@@ -228,7 +228,7 @@ var _ = Describe("SentPacketHandler", func() {
Expect(acked[1].PacketNumber).To(Equal(protocol.PacketNumber(2)))
Expect(acked[2].PacketNumber).To(Equal(protocol.PacketNumber(3)))
Expect(acked[3].PacketNumber).To(Equal(protocol.PacketNumber(4)))
Expect(lost).To(HaveLen(0))
Expect(lost).To(BeEmpty())
})
It("completely processes an ACK with a NACK range", func() {
@@ -263,7 +263,7 @@ var _ = Describe("SentPacketHandler", func() {
Expect(acked[1].PacketNumber).To(Equal(protocol.PacketNumber(2)))
Expect(acked[2].PacketNumber).To(Equal(protocol.PacketNumber(6)))
Expect(acked[3].PacketNumber).To(Equal(protocol.PacketNumber(4)))
Expect(lost).To(HaveLen(0))
Expect(lost).To(BeEmpty())
})
})
@@ -375,7 +375,7 @@ var _ = Describe("SentPacketHandler", func() {
handler.nackPacket(2)
handler.nackPacket(2)
Expect(handler.HasPacketForRetransmission()).To(BeTrue())
Expect(len(handler.retransmissionQueue)).To(Equal(1))
Expect(handler.retransmissionQueue).To(HaveLen(1))
Expect(handler.retransmissionQueue[0].PacketNumber).To(Equal(protocol.PacketNumber(2)))
})