gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

Merge pull request #578 from lucas-clemente/fix-session-flakiness

Browse Source 
fix several flaky session tests
This commit is contained in:
Marten Seemann
2017-05-04 13:03:01 +08:00
committed by GitHub
parent 5f25ffc795 6263c07a49
commit 53583059d9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
session_test.go
View File

@@ -1217,7 +1217,7 @@ var _ = Describe("Session", func() {
It("sets a deadline to send a Public Reset after receiving too many undecryptable packets", func() { It("sets a deadline to send a Public Reset after receiving too many undecryptable packets", func() {
go sess.run() go sess.run()
sendUndecryptablePackets() sendUndecryptablePackets()
Eventually(func() time.Time { return sess.receivedTooManyUndecrytablePacketsTime }).Should(BeTemporally("~", time.Now(), 10*time.Millisecond)) Eventually(func() time.Time { return sess.receivedTooManyUndecrytablePacketsTime }).Should(BeTemporally("~", time.Now(), 20*time.Millisecond))
sess.Close(nil) sess.Close(nil)
}) })
@@ -1233,14 +1233,14 @@ var _ = Describe("Session", func() {
It("sends a Public Reset after a timeout", func() { It("sends a Public Reset after a timeout", func() {
go sess.run() go sess.run()
sendUndecryptablePackets() sendUndecryptablePackets()
Eventually(func() time.Time { return sess.receivedTooManyUndecrytablePacketsTime }).Should(BeTemporally("~", time.Now(), time.Millisecond)) Eventually(func() time.Time { return sess.receivedTooManyUndecrytablePacketsTime }).Should(BeTemporally("~", time.Now(), 10*time.Millisecond))
// speed up this test by manually setting back the time when too many packets were received // speed up this test by manually setting back the time when too many packets were received
sess.receivedTooManyUndecrytablePacketsTime = time.Now().Add(-protocol.PublicResetTimeout) sess.receivedTooManyUndecrytablePacketsTime = time.Now().Add(-protocol.PublicResetTimeout)
time.Sleep(10 * time.Millisecond) // wait for the run loop to spin up time.Sleep(10 * time.Millisecond) // wait for the run loop to spin up
sess.scheduleSending() // wake up the run loop sess.scheduleSending() // wake up the run loop
Eventually(func() [][]byte { return mconn.written }).Should(HaveLen(1)) Eventually(func() [][]byte { return mconn.written }).Should(HaveLen(1))
Expect(mconn.written[0]).To(ContainSubstring(string([]byte("PRST")))) Expect(mconn.written[0]).To(ContainSubstring(string([]byte("PRST"))))
Expect(sess.runClosed).To(Receive()) Eventually(sess.runClosed).Should(Receive())
}) })
It("doesn't send a Public Reset if decrypting them suceeded during the timeout", func() { It("doesn't send a Public Reset if decrypting them suceeded during the timeout", func() {