gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove the internal error for RST_STREAM frames for closed streams

Browse Source
This commit is contained in:
Marten Seemann
2017-12-10 23:34:09 +07:00
parent ba4e980876
commit 51c5cc46d8
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
session.go
View File

@@ -31,10 +31,6 @@ type receivedPacket struct {
rcvTime time.Time rcvTime time.Time
} }
var (
errRstStreamOnInvalidStream = errors.New("RST_STREAM received for unknown stream")
)
var ( var (
newCryptoSetup = handshake.NewCryptoSetup newCryptoSetup = handshake.NewCryptoSetup
newCryptoSetupClient = handshake.NewCryptoSetupClient newCryptoSetupClient = handshake.NewCryptoSetupClient
@@ -547,9 +543,6 @@ func (s *session) handleFrames(fs []wire.Frame, encLevel protocol.EncryptionLeve
switch err { switch err {
case ackhandler.ErrDuplicateOrOutOfOrderAck: case ackhandler.ErrDuplicateOrOutOfOrderAck:
// Can happen e.g. when packets thought missing arrive late // Can happen e.g. when packets thought missing arrive late
case errRstStreamOnInvalidStream:
// Can happen when RST_STREAMs arrive early or late (?)
utils.Errorf("Ignoring error in session: %s", err.Error())
default: default:
return err return err
} }
@@ -607,7 +600,8 @@ func (s *session) handleRstStreamFrame(frame *wire.RstStreamFrame) error {
return err return err
} }
if str == nil { if str == nil {
return errRstStreamOnInvalidStream // stream is closed and already garbage collected
return nil
} }
return str.RegisterRemoteError(fmt.Errorf("RST_STREAM received with code %d", frame.ErrorCode), frame.ByteOffset) return str.RegisterRemoteError(fmt.Errorf("RST_STREAM received with code %d", frame.ErrorCode), frame.ByteOffset)
} }