gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix typos in error messages when parsing Version Negotiation packets

Browse Source
This commit is contained in:
Marten Seemann
2019-06-29 11:00:57 +07:00
parent 0333f424bb
commit 4fe0f6752c
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/wire/header.go
View File

@@ -208,10 +208,10 @@ func (h *Header) parseLongHeader(b *bytes.Reader) error {
func (h *Header) parseVersionNegotiationPacket(b *bytes.Reader) error { func (h *Header) parseVersionNegotiationPacket(b *bytes.Reader) error {
if b.Len() == 0 { if b.Len() == 0 {
return errors.New("Version Negoation packet has empty version list") return errors.New("Version Negotiation packet has empty version list")
} }
if b.Len()%4 != 0 { if b.Len()%4 != 0 {
return errors.New("Version Negotation packet has a version list with an invalid length") return errors.New("Version Negotiation packet has a version list with an invalid length")
} }
h.SupportedVersions = make([]protocol.VersionNumber, b.Len()/4) h.SupportedVersions = make([]protocol.VersionNumber, b.Len()/4)
for i := 0; b.Len() > 0; i++ { for i := 0; b.Len() > 0; i++ {

4
internal/wire/header_test.go
View File

@@ -137,7 +137,7 @@ var _ = Describe("Header Parsing", func() {
data, err := ComposeVersionNegotiation(connID, connID, versions) data, err := ComposeVersionNegotiation(connID, connID, versions)
Expect(err).ToNot(HaveOccurred()) Expect(err).ToNot(HaveOccurred())
_, _, _, err = ParsePacket(data[:len(data)-2], 0) _, _, _, err = ParsePacket(data[:len(data)-2], 0)
Expect(err).To(MatchError("Version Negotation packet has a version list with an invalid length")) Expect(err).To(MatchError("Version Negotiation packet has a version list with an invalid length"))
}) })
It("errors if the version list is empty", func() { It("errors if the version list is empty", func() {
@@ -148,7 +148,7 @@ var _ = Describe("Header Parsing", func() {
// remove 8 bytes (two versions), since ComposeVersionNegotiation also added a reserved version number // remove 8 bytes (two versions), since ComposeVersionNegotiation also added a reserved version number
data = data[:len(data)-8] data = data[:len(data)-8]
_, _, _, err = ParsePacket(data, 0) _, _, _, err = ParsePacket(data, 0)
Expect(err).To(MatchError("Version Negoation packet has empty version list")) Expect(err).To(MatchError("Version Negotiation packet has empty version list"))
}) })
}) })