fix race condition in GetStream in outgoing streams map

2018-02-22 09:21:59 +08:00
parent 77a4bf17ca
commit 4fa68b0788
6 changed files with 15 additions and 3 deletions
--- a/streams_map_outgoing_generic.go
+++ b/streams_map_outgoing_generic.go
@@ -86,10 +86,11 @@ func (m *outgoingItemsMap) openStreamImpl() (item, error) {
 }

 func (m *outgoingItemsMap) GetStream(id protocol.StreamID) (item, error) {
+	m.mutex.RLock()
 	if id >= m.nextStream {
+		m.mutex.RUnlock()
 		return nil, qerr.Error(qerr.InvalidStreamID, fmt.Sprintf("peer attempted to open stream %d", id))
 	}
-	m.mutex.RLock()
 	s := m.streams[id]
 	m.mutex.RUnlock()
 	return s, nil