gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

Remove PackPacket's control frames parameter

Browse Source 
With this change it would theoretically be possible for outdated control frames to be sent, but this is quite unlikely in practice.
This commit is contained in:
Lucas Clemente
2017-06-19 17:26:15 +02:00
parent d7ddadc7b7
commit 495399ede6
3 changed files with 47 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packet_packer.go
View File

@@ -71,8 +71,7 @@ func (p *packetPacker) RetransmitNonForwardSecurePacket(stopWaitingFrame *frames
// PackPacket packs a new packet
// the stopWaitingFrame is *guaranteed* to be included in the next packet
// the other controlFrames are sent in the next packet, but might be queued and sent in the next packet if the packet would overflow MaxPacketSize otherwise
func (p *packetPacker) PackPacket(stopWaitingFrame *frames.StopWaitingFrame, controlFrames []frames.Frame, leastUnacked protocol.PacketNumber) (*packedPacket, error) {
p.controlFrames = append(p.controlFrames, controlFrames...)
func (p *packetPacker) PackPacket(stopWaitingFrame *frames.StopWaitingFrame, leastUnacked protocol.PacketNumber) (*packedPacket, error) {
return p.packPacket(stopWaitingFrame, leastUnacked, nil)
}