gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix PublicHeader of VersionNegotiation and PublicReset packets

Browse Source 
fixes #71
This commit is contained in:
Marten Seemann
2016-05-09 22:27:55 +07:00
parent 7bf94df817
commit 476acc2966
3 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
public_header.go
View File

@@ -50,7 +50,10 @@ func (h *PublicHeader) WritePublicHeader(b *bytes.Buffer) error {
utils.WriteUint64(b, uint64(h.ConnectionID))
}
utils.WriteUint48(b, uint64(h.PacketNumber)) // TODO: Send shorter packet number if possible
if !h.ResetFlag && !h.VersionFlag {
utils.WriteUint48(b, uint64(h.PacketNumber)) // TODO: Send shorter packet number if possible
}
return nil
}

4
public_header_test.go
View File

@@ -97,6 +97,8 @@ var _ = Describe("Public Header", func() {
PacketNumber: 2,
}
publicHeader.WritePublicHeader(b)
// must be the first assertion
Expect(b.Len()).To(Equal(1 + 8)) // 1 FlagByte + 8 ConnectionID
firstByte, _ := b.ReadByte()
Expect(firstByte & 0x01).To(Equal(uint8(1)))
})
@@ -109,6 +111,8 @@ var _ = Describe("Public Header", func() {
PacketNumber: 2,
}
publicHeader.WritePublicHeader(b)
// must be the first assertion
Expect(b.Len()).To(Equal(1 + 8)) // 1 FlagByte + 8 ConnectionID
firstByte, _ := b.ReadByte()
Expect((firstByte & 0x02) >> 1).To(Equal(uint8(1)))
})

2
server_test.go
View File

@@ -47,7 +47,7 @@ var _ = Describe("Server", func() {
It("composes version negotiation packets", func() {
expected := append(
[]byte{0x3d, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0},
[]byte{0x3d, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0},
protocol.SupportedVersionsAsTags...,
)
Expect(composeVersionNegotiation(1)).To(Equal(expected))