From 4384df18a317f5c103b7b5f653c2968eeda62a34 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sat, 1 Jul 2023 10:09:32 -0700 Subject: [PATCH] disable GSO unless QUIC_GO_ENABLE_GSO is set (#3934) --- .github/workflows/integration.yml | 4 ++-- sys_conn_df_linux.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index a7776c0a..b1638e5a 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -34,10 +34,10 @@ jobs: - name: Run self tests, using QUIC v2 if: success() || failure() # run this step even if the previous one failed run: go run github.com/onsi/ginkgo/v2/ginkgo -r -v -randomize-all -randomize-suites -trace integrationtests/self -- -version=2 ${{ env.QLOGFLAG }} - - name: Run set tests, with GSO disabled + - name: Run set tests, with GSO enabled if: success() || failure() # run this step even if the previous one failed env: - QUIC_GO_DISABLE_GSO: true + QUIC_GO_ENABLE_GSO: true run: go run github.com/onsi/ginkgo/v2/ginkgo -r -v -randomize-all -randomize-suites -trace integrationtests/self -- -version=1 ${{ env.QLOGFLAG }} - name: Run tests (32 bit) if: success() || failure() # run this step even if the previous one failed diff --git a/sys_conn_df_linux.go b/sys_conn_df_linux.go index f027b47a..92f7e725 100644 --- a/sys_conn_df_linux.go +++ b/sys_conn_df_linux.go @@ -44,8 +44,8 @@ func setDF(rawConn syscall.RawConn) (bool, error) { } func maybeSetGSO(rawConn syscall.RawConn) bool { - disable, _ := strconv.ParseBool(os.Getenv("QUIC_GO_DISABLE_GSO")) - if disable { + enable, _ := strconv.ParseBool(os.Getenv("QUIC_GO_ENABLE_GSO")) + if !enable { return false }