gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix flaky TestDrainServerAcceptQueue (#5247)

Browse Source 
The connections are not necessarily accepted in the same order that
they are dialed.
This commit is contained in:
Marten Seemann
2025-06-28 15:37:18 +08:00
committed by GitHub
parent 08e9c7e7ac
commit 3f3d3099b7
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
integrationtests/self/close_test.go
View File

@@ -95,7 +95,7 @@ func TestDrainServerAcceptQueue(t *testing.T) {
defer cancel() defer cancel()
// fill up the accept queue // fill up the accept queue
conns := make([]*quic.Conn, 0, protocol.MaxAcceptQueueSize) conns := make([]*quic.Conn, 0, protocol.MaxAcceptQueueSize)
for i := 0; i < protocol.MaxAcceptQueueSize; i++ { for range protocol.MaxAcceptQueueSize {
conn, err := dialer.Dial(ctx, server.Addr(), getTLSClientConfig(), getQuicConfig(nil)) conn, err := dialer.Dial(ctx, server.Addr(), getTLSClientConfig(), getQuicConfig(nil))
require.NoError(t, err) require.NoError(t, err)
conns = append(conns, conn) conns = append(conns, conn)
@@ -107,9 +107,8 @@ func TestDrainServerAcceptQueue(t *testing.T) {
c, err := server.Accept(ctx) c, err := server.Accept(ctx)
require.NoError(t, err) require.NoError(t, err)
// make sure the connection is not closed // make sure the connection is not closed
require.NoError(t, conns[i].Context().Err(), "client connection closed") require.NoError(t, context.Cause(conns[i].Context()), "client connection closed")
require.NoError(t, c.Context().Err(), "server connection closed") require.NoError(t, context.Cause(c.Context()), "server connection closed")
conns[i].CloseWithError(0, "")
c.CloseWithError(0, "") c.CloseWithError(0, "")
} }
_, err = server.Accept(ctx) _, err = server.Accept(ctx)